Commit0eafe20

committed

Add test case as example of Git commit with invalid data

This is a real commit from the microjs.com open source project, seemicrojs/microjs.com@7e8457c,which is declared to be encoded in UTF-8, but contains invalid bytes.This makes GitPython choke on it while decoding. Rather than choking,this should instead accept the error and replace the invalid bytes bythe � (\x80) char.

1 parente836e5c commit0eafe20Copy full SHA for 0eafe20

File tree

2 files changed

+13

-0

lines changed

git/test
- fixtures
  - commit_invalid_data
- test_commit.py

2 files changed

+13

-0

lines changed

`‎git/test/fixtures/commit_invalid_data`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,6 @@`
	`1`	`+tree 9f1a495d7d9692d24f5caedaa89f5c2c32d59368`
	`2`	`+parent 492ace2ffce0e426ebeb55e364e987bcf024dd3b`
	`3`	`+author E.Azer Ko�o�o�oculu <azer@kodfabrik.com> 1306710073 +0300`
	`4`	`+committer E.Azer Ko�o�o�oculu <azer@kodfabrik.com> 1306710073 +0300`
	`5`	`+`
	`6`	`+add environjs`

`‎git/test/test_commit.py`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -306,6 +306,13 @@ def test_serialization_unicode_support(self):`
`306`	`306`	`# it appears`
`307`	`307`	`cmt.author.__repr__()`
`308`	`308`
	`309`	`+deftest_invalid_commit(self):`
	`310`	`+cmt=self.rorepo.commit()`
	`311`	`+cmt._deserialize(open(fixture_path('commit_invalid_data'),'rb'))`
	`312`	`+`
	`313`	`+assertcmt.author.name==u'E.Azer Ko�o�o�oculu',cmt.author.name`
	`314`	`+assertcmt.author.email=='azer@kodfabrik.com',cmt.author.email`
	`315`	`+`
`309`	`316`	`deftest_gpgsig(self):`
`310`	`317`	`cmt=self.rorepo.commit()`
`311`	`318`	`cmt._deserialize(open(fixture_path('commit_with_gpgsig'),'rb'))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit0eafe20

File tree

2 files changed

2 files changed

`‎git/test/fixtures/commit_invalid_data`

`‎git/test/test_commit.py`

0 commit comments