Commit0e311bf

committed

Suppress type errors in restore_use_shell_state _USE_SHELL branches

These conditional branches are kept so alternative implementationscan be examined, including if they need to be investigated tosatisfy some future requirement. But to be unittest.mock.patchpatchable, the approaches that would have a _USE_SHELL backingattribute would be difficult to implement in a straightforward way,which seems not to be needed or justified at this time.Since that is not anticipated (except as an intermediate step indevelopment), these suppressions make sense, and they will also bereported by mypy if the implementation changes to benefit from them(so long as it is configured with warn_unused_ignores set to true).

1 parent4037108 commit0e311bfCopy full SHA for 0e311bf

File tree

1 file changed

-2

lines changed

test/deprecation
- test_cmd_git.py

1 file changed

-2

lines changed

`‎test/deprecation/test_cmd_git.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ def restore_use_shell_state() -> Generator[None, None, None]:`
`111`	`111`
`112`	`112`	`# Try to save the original private state.`
`113`	`113`	`try:`
`114`		`-old_private_value=Git._USE_SHELL`
	`114`	`+old_private_value=Git._USE_SHELL# type: ignore[attr-defined]`
`115`	`115`	`exceptAttributeError:`
`116`	`116`	`separate_backing_attribute=False`
`117`	`117`	`try:`
`@@ -139,7 +139,7 @@ def restore_use_shell_state() -> Generator[None, None, None]:`
`139`	`139`	`finally:`
`140`	`140`	`# Try to restore the original private state.`
`141`	`141`	`ifseparate_backing_attribute:`
`142`		`-Git._USE_SHELL=old_private_value`
	`142`	`+Git._USE_SHELL=old_private_value# type: ignore[attr-defined]`
`143`	`143`	`elifold_private_valueisnotno_value:`
`144`	`144`	`type.__setattr__(Git,"USE_SHELL",old_private_value)`
`145`	`145`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit0e311bf

File tree

1 file changed

1 file changed

`‎test/deprecation/test_cmd_git.py`

0 commit comments