Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(action): fix unhandled promise rejection#32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

benatshippabo
Copy link
Contributor

@benatshippabobenatshippabo commentedAug 18, 2021•
edited
Loading

Summary

This fixes the unhandled promise rejection when something errors out insidemain. An example would be when one of the git commands fail such as pushing to a write protected branch, you would see this message but the action still passes:

(node:1625) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)(node:1625) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

It is fixed by usingcore.setFailed documentedhere.

Related issues:#2#9

@Wattenberger
Copy link
Contributor

this is great, thanks for the PR!

benatshippabo reacted with hooray emoji

@WattenbergerWattenberger merged commiteb6863e intogithubocto:mainAug 18, 2021
ageorgou added a commit to ageorgou/repo-visualizer that referenced this pull requestAug 22, 2021
@ageorgouageorgou mentioned this pull requestAug 22, 2021
Wattenberger pushed a commit that referenced this pull requestAug 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@benatshippabo@Wattenberger
[8]ページ先頭
©2009-2025 Movatter.jp