Commite02af8e

authored

Fix issue where sometimes modified timestamp file was not shown in baseline (microsoft#58623)

1 parentb682ed4 commite02af8eCopy full SHA for e02af8e

File tree

+19

-2

lines changed

+19

-2

lines changed

Lines changed: 11 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -788,8 +788,8 @@ export class FileSystem {`
`788`	`788`	`}`
`789`	`789`
`790`	`790`	`privatestaticfileDiff(container:FileSet,basename:string,changed:FileSystem,changedNode:FileInode,base:FileSystem,baseNode:FileInode,options:DiffOptions){`
`791`		`-while(!changedNode.buffer&&changedNode.shadowRoot)changedNode=changedNode.shadowRoot;`
`792`		`-while(!baseNode.buffer&&baseNode.shadowRoot)baseNode=baseNode.shadowRoot;`
	`791`	`+changedNode=walkSameNodes(changedNode);`
	`792`	`+baseNode=walkSameNodes(baseNode);`
`793`	`793`
`794`	`794`	`// no difference if the nodes are the same reference`
`795`	`795`	`if(changedNode===baseNode)returnfalse;`
`@@ -827,6 +827,15 @@ export class FileSystem {`
`827`	`827`
`828`	`828`	`container[basename]=newFile(changedBuffer.data,{encoding:changedBuffer.encoding});`
`829`	`829`	`returntrue;`
	`830`	`+`
	`831`	`+functionwalkSameNodes(node:FileInode){`
	`832`	`+while(`
	`833`	`+!node.buffer&&`
	`834`	`+node.shadowRoot&&`
	`835`	`+(!options.includeChangedFileWithSameContent\|\|node.mtimeMs===node.shadowRoot.mtimeMs)`
	`836`	`+)node=node.shadowRoot;`
	`837`	`+returnnode;`
	`838`	`+}`
`830`	`839`	`}`
`831`	`840`
`832`	`841`	`privatestaticsymlinkDiff(container:FileSet,basename:string,changedNode:SymlinkInode,baseNode:SymlinkInode){`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -565,6 +565,10 @@ function f() {`
`565`	`565`	`"size":1407`
`566`	`566`	`}`
`567`	`567`
	`568`	`+//// [/src/third/thirdjs/output/third-output.d.ts] file changed its modified time`
	`569`	`+//// [/src/third/thirdjs/output/third-output.d.ts.map] file changed its modified time`
	`570`	`+//// [/src/third/thirdjs/output/third-output.js] file changed its modified time`
	`571`	`+//// [/src/third/thirdjs/output/third-output.js.map] file changed its modified time`
`568`	`572`
`569`	`573`
`570`	`574`	`Change::Makeincrementalbuildwithchangeinfilethatdoesntaffectdts`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1390,3 +1390,7 @@ sourceFile:../first_part3.ts`
`1390`	`1390`	`"size":1407`
`1391`	`1391`	`}`
`1392`	`1392`
	`1393`	`+//// [/src/third/thirdjs/output/third-output.d.ts] file changed its modified time`
	`1394`	`+//// [/src/third/thirdjs/output/third-output.d.ts.map] file changed its modified time`
	`1395`	`+//// [/src/third/thirdjs/output/third-output.js] file changed its modified time`
	`1396`	`+//// [/src/third/thirdjs/output/third-output.js.map] file changed its modified time`

Comments

(0)