Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commita203ace

Browse files
Ban inferred return type on async and generator functions. (microsoft#58628)
1 parentddf43cd commita203ace

File tree

5 files changed

+134
-0
lines changed

5 files changed

+134
-0
lines changed

‎src/compiler/checker.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48984,6 +48984,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
4898448984
function getSingleReturnExpression(declaration: SignatureDeclaration | undefined): Expression | undefined {
4898548985
let candidateExpr: Expression | undefined;
4898648986
if (declaration && !nodeIsMissing((declaration as FunctionLikeDeclaration).body)) {
48987+
if (getFunctionFlags(declaration) & FunctionFlags.AsyncGenerator) return undefined;
4898748988
const body = (declaration as FunctionLikeDeclaration).body;
4898848989
if (body && isBlock(body)) {
4898948990
forEachReturnStatement(body, s => {

‎src/compiler/expressionToTypeNode.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,12 @@ import {
1414
Expression,
1515
forEachReturnStatement,
1616
FunctionExpression,
17+
FunctionFlags,
1718
FunctionLikeDeclaration,
1819
GetAccessorDeclaration,
1920
getEffectiveReturnTypeNode,
2021
getEffectiveTypeAnnotationNode,
22+
getFunctionFlags,
2123
getJSDocTypeAssertionType,
2224
getStrictOptionValue,
2325
HasInferredType,
@@ -469,6 +471,8 @@ export function createSyntacticTypeNodeBuilder(options: CompilerOptions, resolve
469471
functiontypeFromSingleReturnExpression(declaration:FunctionLikeDeclaration|undefined,context:SyntacticTypeNodeBuilderContext):boolean|undefined{
470472
letcandidateExpr:Expression|undefined;
471473
if(declaration&&!nodeIsMissing(declaration.body)){
474+
if(getFunctionFlags(declaration)&FunctionFlags.AsyncGenerator)returnundefined;
475+
472476
constbody=declaration.body;
473477
if(body&&isBlock(body)){
474478
forEachReturnStatement(body,s=>{
Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
//// [declarationAsyncAndGeneratorFunctions.ts] ////
2+
exportasyncfunctionasyncFn(){
3+
return{}asPromise<void>
4+
}
5+
6+
exportasyncfunctionasyncFn2(){
7+
return{}asnumber
8+
}
9+
10+
exportasyncfunctionasyncFn3(){
11+
return(await42)asnumber;
12+
}
13+
14+
exportfunction*generatorFn(){
15+
return{}asnumber
16+
}
17+
18+
exportasyncfunction*asyncGeneratorFn(){
19+
return{}asnumber
20+
}
21+
//// [declarationAsyncAndGeneratorFunctions.d.ts] ////
22+
exportdeclarefunctionasyncFn():unknown;
23+
exportdeclarefunctionasyncFn2():unknown;
24+
exportdeclarefunctionasyncFn3():unknown;
25+
exportdeclarefunctiongeneratorFn():{};
26+
exportdeclarefunctionasyncGeneratorFn():{};
27+
28+
29+
//// [Diagnostics reported]
30+
declarationAsyncAndGeneratorFunctions.ts(1,23):error TS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
31+
declarationAsyncAndGeneratorFunctions.ts(5,23):errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
32+
declarationAsyncAndGeneratorFunctions.ts(9,23):errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
33+
declarationAsyncAndGeneratorFunctions.ts(13,18):errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
34+
declarationAsyncAndGeneratorFunctions.ts(17,24):errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
35+
36+
37+
====declarationAsyncAndGeneratorFunctions.ts(5errors)====
38+
exportasyncfunctionasyncFn(){
39+
~~~~~~~
40+
!!!errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
41+
!!!relatedTS9031declarationAsyncAndGeneratorFunctions.ts:1:23:Addareturntypetothefunctiondeclaration.
42+
return{}asPromise<void>
43+
}
44+
45+
exportasyncfunctionasyncFn2(){
46+
~~~~~~~~
47+
!!!errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
48+
!!!relatedTS9031declarationAsyncAndGeneratorFunctions.ts:5:23:Addareturntypetothefunctiondeclaration.
49+
return{}asnumber
50+
}
51+
52+
exportasyncfunctionasyncFn3(){
53+
~~~~~~~~
54+
!!!errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
55+
!!!relatedTS9031declarationAsyncAndGeneratorFunctions.ts:9:23:Addareturntypetothefunctiondeclaration.
56+
return(await42)asnumber;
57+
}
58+
59+
exportfunction*generatorFn(){
60+
~~~~~~~~~~~
61+
!!!errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
62+
!!!relatedTS9031declarationAsyncAndGeneratorFunctions.ts:13:18:Addareturntypetothefunctiondeclaration.
63+
return{}asnumber
64+
}
65+
66+
exportasyncfunction*asyncGeneratorFn(){
67+
~~~~~~~~~~~~~~~~
68+
!!!errorTS9007:Functionmusthaveanexplicitreturntypeannotationwith--isolatedDeclarations.
69+
!!!relatedTS9031declarationAsyncAndGeneratorFunctions.ts:17:24:Addareturntypetothefunctiondeclaration.
70+
return{}asnumber
71+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
//// [declarationAsyncAndGeneratorFunctions.ts] ////
2+
exportasyncfunctionasyncFn(){
3+
return{}asPromise<void>
4+
}
5+
6+
exportasyncfunctionasyncFn2(){
7+
return{}asnumber
8+
}
9+
10+
exportasyncfunctionasyncFn3(){
11+
return(await42)asnumber;
12+
}
13+
14+
exportfunction*generatorFn(){
15+
return{}asnumber
16+
}
17+
18+
exportasyncfunction*asyncGeneratorFn(){
19+
return{}asnumber
20+
}
21+
//// [declarationAsyncAndGeneratorFunctions.js] ////
22+
exportasyncfunctionasyncFn(){
23+
return{};
24+
}
25+
exportasyncfunctionasyncFn2(){
26+
return{};
27+
}
28+
exportasyncfunctionasyncFn3(){
29+
return(await42);
30+
}
31+
exportfunction*generatorFn(){
32+
return{};
33+
}
34+
exportasyncfunction*asyncGeneratorFn(){
35+
return{};
36+
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
//@declaration: true
2+
//@target: esnext
3+
4+
exportasyncfunctionasyncFn(){
5+
return{}asPromise<void>
6+
}
7+
8+
exportasyncfunctionasyncFn2(){
9+
return{}asnumber
10+
}
11+
12+
exportasyncfunctionasyncFn3(){
13+
return(await42)asnumber;
14+
}
15+
16+
exportfunction*generatorFn(){
17+
return{}asnumber
18+
}
19+
20+
exportasyncfunction*asyncGeneratorFn(){
21+
return{}asnumber
22+
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp