Commitbccdb48

committed

test: Make git-daemon only listen on localhost

No reason to expose a daemon to all interfaces when it is only used fortests, which connect to localhost anyway.I'd love to use localhost here instead, but the git-daemon man page points out: If IPv6 is not supported, then --listen=hostname is also not supported and --listen must be given an IPv4 address.I don't know of a way to check if git has ipv6 support, but 127.0.0.1should be around for the foreseeable future

1 parent5fe80b0 commitbccdb48Copy full SHA for bccdb48

File tree

1 file changed

-1

lines changed

git/test/lib
- helper.py

1 file changed

-1

lines changed

`‎git/test/lib/helper.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ def remote_repo_creator(self):`
`200`	`200`	`temp_dir=osp(_mktemp())`
`201`	`201`	`# On windows, this will fail ... we deal with failures anyway and default to telling the user to do it`
`202`	`202`	`try:`
`203`		`-gd=Git().daemon(temp_dir,enable='receive-pack',as_process=True)`
	`203`	`+gd=Git().daemon(temp_dir,enable='receive-pack',listen='127.0.0.1',as_process=True)`
`204`	`204`	`# yes, I know ... fortunately, this is always going to work if sleep time is just large enough`
`205`	`205`	`time.sleep(0.5)`
`206`	`206`	`exceptException:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbccdb48

File tree

1 file changed

1 file changed

`‎git/test/lib/helper.py`

0 commit comments