Commit7ec3d39

committed

Merge pull requestsigmavirus24#230 from aalexandrov/patch-1

Wrong argument name in Organization.create_team()

2 parents480349c +5baf57a commit7ec3d39Copy full SHA for 7ec3d39

File tree

-5

lines changed

-5

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -303,14 +303,14 @@ def conceal_member(self, login):`
`303`	`303`	`returnself._boolean(self._delete(url),204,404)`
`304`	`304`
`305`	`305`	`@requires_auth`
`306`		`-defcreate_team(self,name,repo_names=[],permissions=''):`
	`306`	`+defcreate_team(self,name,repo_names=[],permission=''):`
`307`	`307`	`"""Assuming the authenticated user owns this organization,`
`308`	`308`	`create and return a new team.`
`309`	`309`
`310`	`310`	`:param str name: (required), name to be given to the team`
`311`	`311`	`:param list repo_names: (optional) repositories, e.g.`
`312`	`312`	`['github/dotfiles']`
`313`		`- :param strpermissions: (optional), options:`
	`313`	`+ :param strpermission: (optional), options:`
`314`	`314`
`315`	`315`	- ``pull`` -- (default) members can not push or administer
`316`	`316`	`repositories accessible by this team`
`@@ -322,7 +322,7 @@ def create_team(self, name, repo_names=[], permissions=''):`
`322`	`322`	:returns: :class:`Team <Team>`
`323`	`323`	`"""`
`324`	`324`	`data= {'name':name,'repo_names':repo_names,`
`325`		`-'permissions':permissions}`
	`325`	`+'permission':permission}`
`326`	`326`	`url=self._build_url('teams',base_url=self._api)`
`327`	`327`	`json=self._json(self._post(url,data),201)`
`328`	`328`	`returnTeam(json,self._session)ifjsonelseNone`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -214,15 +214,15 @@ def test_create_team(self):`
`214`	`214`	`'data': {`
`215`	`215`	`'name':'team',`
`216`	`216`	`'repo_names': [],`
`217`		`-'permissions':'push'`
	`217`	`+'permission':'push'`
`218`	`218`	`}`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`self.assertRaises(github3.GitHubError,self.org.create_team,None)`
`222`	`222`
`223`	`223`	`self.not_called()`
`224`	`224`	`self.login()`
`225`		`-assertisinstance(self.org.create_team('team',permissions='push'),`
	`225`	`+assertisinstance(self.org.create_team('team',permission='push'),`
`226`	`226`	`github3.orgs.Team)`
`227`	`227`	`self.mock_assertions()`
`228`	`228`

Comments

(0)