Commit12b0df2

committed

Merge pull requestsigmavirus24#316 from rweald/stop_using_deployment_headers

Don't use custom header for Deployment requests

2 parents84bb636 +f79febb commit12b0df2Copy full SHA for 12b0df2

File tree

-16

lines changed

-16

lines changed

Lines changed: 2 additions & 0 deletions

Lines changed: 1 addition & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,10 +6,6 @@`
`6`	`6`
`7`	`7`
`8`	`8`	`classDeployment(GitHubCore):`
`9`		`-CUSTOM_HEADERS= {`
`10`		`-'Accept':'application/vnd.github.cannonball-preview+json'`
`11`		`- }`
`12`		`-`
`13`	`9`	`def_update_attributes(self,deployment):`
`14`	`10`	`self._api=deployment.get('url')`
`15`	`11`
`@@ -67,8 +63,7 @@ def create_status(self, state, target_url=None, description=None):`
`67`	`63`	`data= {'state':state,'target_url':target_url,`
`68`	`64`	`'description':description}`
`69`	`65`	`self._remove_none(data)`
`70`		`-response=self._post(self.statuses_url,data=data,`
`71`		`-headers=Deployment.CUSTOM_HEADERS)`
	`66`	`+response=self._post(self.statuses_url,data=data)`
`72`	`67`	`json=self._json(response,201)`
`73`	`68`
`74`	`69`	`returnself._instance_or_null(DeploymentStatus,json)`
`@@ -84,7 +79,6 @@ def statuses(self, number=-1, etag=None):`
`84`	`79`	`"""`
`85`	`80`	`i=self._iter(int(number),self.statuses_url,DeploymentStatus,`
`86`	`81`	`etag=etag)`
`87`		`-i.headers=Deployment.CUSTOM_HEADERS`
`88`	`82`	`returni`
`89`	`83`
`90`	`84`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -724,8 +724,7 @@ def create_deployment(self, ref, force=False, payload='',`
`724`	`724`	`'auto_merge':auto_merge,'description':description,`
`725`	`725`	`'environment':environment}`
`726`	`726`	`self._remove_none(data)`
`727`		`-headers=Deployment.CUSTOM_HEADERS`
`728`		`-json=self._json(self._post(url,data=data,headers=headers),`
	`727`	`+json=self._json(self._post(url,data=data),`
`729`	`728`	`201)`
`730`	`729`	`returnself._instance_or_null(Deployment,json)`
`731`	`730`
`@@ -1091,7 +1090,6 @@ def deployments(self, number=-1, etag=None):`
`1091`	`1090`	`"""`
`1092`	`1091`	`url=self._build_url('deployments',base_url=self._api)`
`1093`	`1092`	`i=self._iter(int(number),url,Deployment,etag=etag)`
`1094`		`-i.headers.update(Deployment.CUSTOM_HEADERS)`
`1095`	`1093`	`returni`
`1096`	`1094`
`1097`	`1095`	`@requires_auth`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,5 @@ def test_statuses(self):`
`64`	`64`	`self.session.get.assert_called_once_with(`
`65`	`65`	`url_for('statuses'),`
`66`	`66`	`params={'per_page':100},`
`67`		`-headers={`
`68`		`-'Accept':'application/vnd.github.cannonball-preview+json'`
`69`		`- }`
	`67`	`+headers={}`
`70`	`68`	`)`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -384,9 +384,7 @@ def test_deployments(self):`
`384`	`384`	`self.session.get.assert_called_once_with(`
`385`	`385`	`url_for('deployments'),`
`386`	`386`	`params={'per_page':100},`
`387`		`-headers={`
`388`		`-'Accept':'application/vnd.github.cannonball-preview+json'`
`389`		`- }`
	`387`	`+headers={}`
`390`	`388`	`)`
`391`	`389`
`392`	`390`	`deftest_events(self):`

Comments

(0)