- Notifications
You must be signed in to change notification settings - Fork318
Massive Refactor (part II) 🍻 - WIP#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
224244c tocb832f8Compare7450e33 tod2e4adaComparecodecov-io commentedSep 25, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #85 +/- ##========================================= Coverage ? 79.27% ========================================= Files ? 7 Lines ? 333 Branches ? 0 ========================================= Hits ? 264 Misses ? 69 Partials ? 0
Continue to review full report at Codecov.
|
194605d to9777c38Compareddc0d16 tobf4eeaeComparec9655cf to7d7e99dCompare7d7e99d to3e808f4Compare3e808f4 to51abd84Compare51abd84 to097fd67Compare3054bbf toa1a8d37Comparealexcanessa added a commit that referenced this pull requestSep 29, 2017
* Add all the defaults to Release.js* First change for README.md file* Create Gren task and add functionality for the changelog command* Update node version in travis* Change the task for the Gren* Update options description* Use native Object.assign for the program options to avoid deep merging* Prettify the utils task logger* Accept * as all tags* Get github env informations from Program.js* Update the generated documentation* Change the name in the docs* Update documentation* Add code coverage with mocha/istanbul* Update organisation name in the package.json* Get the token from process.env rather than command* Update documentation* Create tests* Add npm downloads badge
Merged
alexcanessa added a commit that referenced this pull requestOct 8, 2017
* Add all the defaults to Release.js* First change for README.md file* Create Gren task and add functionality for the changelog command* Update node version in travis* Change the task for the Gren* Update options description* Use native Object.assign for the program options to avoid deep merging* Prettify the utils task logger* Accept * as all tags* Get github env informations from Program.js* Update the generated documentation* Change the name in the docs* Update documentation* Add code coverage with mocha/istanbul* Update organisation name in the package.json* Get the token from process.env rather than command* Update documentation* Create tests* Add npm downloads badge
This was referencedOct 8, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is a massive PR, indeedDocs
Lot of work of this PR has been done to make the documentation more readable.
Options and Examples
contributes to#66 and#80 (already started in#82).
Options and Examples are now implemented in the
grencommand and both generate yml files in thedocsfolder, to feedjekyll.The documentation now implements the options and the examples shown on the terminal.
README.mdresolves#78
Updated the
README.mdfile to reflectOptions and Examples and removed it from thedocswhere now the homepage is just the navigation (don't need a duplicate for that).Testing -currently WIP
resolves#37
Removed
nodeunitand now using the bundlemocha,chai,istanbulandnycto run test and coverage.README.mdfile.Codecovreport on PRs.