fix: index out of range bug#289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

alexcanessa merged 1 commit intogithub-tools:masterfromHarikrishnanBalagopal:fix/index

Dec 17, 2020

Merged

fix: index out of range bug#289

alexcanessa merged 1 commit intogithub-tools:masterfromHarikrishnanBalagopal:fix/index

Dec 17, 2020

Conversation

Copy link

Contributor

HarikrishnanBalagopal commentedDec 13, 2020

The for loop condition needs to depend
on the RANGE, otherwise it the index
will go out of range when we access
i + RANGE - 1 inside the for loop.

Signed-off-by: Harikrishnan Balagopalharikrishmenon@gmail.com

Fixes#288

fix: index out of range bug

12eed89

The for loop condition needs to dependon the RANGE, otherwise it the indexwill go out of range when we accessi + RANGE - 1 inside the for loop.Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>

Copy link

codecov-io commentedDec 13, 2020

Codecov Report

Merging#289 (12eed89) intomaster (d7ad51a) willnot change coverage.
The diff coverage is0.00%.

@@           Coverage Diff           @@##           master     #289   +/-   ##=======================================  Coverage   39.08%   39.08%           =======================================  Files           8        8             Lines         394      394           =======================================  Hits          154      154             Misses        240      240

Impacted Files	Coverage Δ
lib/src/Gren.js	`4.76% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update8c5affc...12eed89. Read thecomment docs.