- Notifications
You must be signed in to change notification settings - Fork318
[Bugfix] Some Pull Requests/Issues/CommitBlocks are missing when generating release notes#263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedFeb 21, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #263 +/- ##=========================================- Coverage 39.28% 39.08% -0.2%========================================= Files 8 8 Lines 392 394 +2 ========================================= Hits 154 154- Misses 238 240 +2
Continue to review full report at Codecov.
|
alexcanessa commentedMar 2, 2020
That's great, thanks@monicarib |
alexcanessa commentedMar 2, 2020
@all-contributors please add@monicarib for code |
I've put upa pull request to add@monicarib! 🎉 |
monicaribeiro commentedMar 5, 2020
@alexcanessa thank you! |
alexcanessa commentedMar 5, 2020
@monicarib yup, will do this evening |
alexcanessa commentedMar 5, 2020
Still some testing happening. Not sure if this is gonna work when no releases are present. |
monicaribeiro commentedMar 6, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@alexcanessa do you have a specific scenario? We could add more unit tests to make sure everything is fine. |
JHFarrant commentedMar 19, 2020
@alexcanessa@monicarib Great fix here :) I thought the whole point is this tool lets us release fast? 😉 |
yogevyuval commentedMar 24, 2020
+1 for making a new release so we can use it. |
Uh oh!
There was an error while loading.Please reload this page.
Issue Description
When running the command:
gren releaseto generate the release notes, the last resource (PR, issue, commit block) was not included on the list.Let's suppose that your data source is Pull Requests.
You open two pull requests, tag them (one as bug, and the other as enhancement), and merge them into master. After creating your release and tag on GitHub, if you generate the notes for the release, the last PR merged was not added into it, and the last PR of the release before (that was not included before) was also, incorrectly, added.
Issues Related
#128
Solution
When getting the actual date of creation of the tag, it was considering the date of last commit of the tag. The solution was to consider the creation date of the release.