Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Bugfix] Some Pull Requests/Issues/CommitBlocks are missing when generating release notes#263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@monicaribeiro
Copy link
Contributor

@monicaribeiromonicaribeiro commentedFeb 21, 2020
edited
Loading

Issue Description

When running the command:gren release to generate the release notes, the last resource (PR, issue, commit block) was not included on the list.

Let's suppose that your data source is Pull Requests.
You open two pull requests, tag them (one as bug, and the other as enhancement), and merge them into master. After creating your release and tag on GitHub, if you generate the notes for the release, the last PR merged was not added into it, and the last PR of the release before (that was not included before) was also, incorrectly, added.

Issues Related

#128

Solution

When getting the actual date of creation of the tag, it was considering the date of last commit of the tag. The solution was to consider the creation date of the release.

rchabin and alexcanessa reacted with thumbs up emoji
@codecov-io
Copy link

codecov-io commentedFeb 21, 2020
edited
Loading

Codecov Report

Merging#263 intomaster willdecrease coverage by0.19%.
The diff coverage is0%.

Impacted file tree graph

@@            Coverage Diff            @@##           master     #263     +/-   ##=========================================- Coverage   39.28%   39.08%   -0.2%=========================================  Files           8        8               Lines         392      394      +2     =========================================  Hits          154      154- Misses        238      240      +2
Impacted FilesCoverage Δ
lib/src/Gren.js4.76% <0%> (-0.05%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateac8f1b9...d7ad51a. Read thecomment docs.

@alexcanessaalexcanessa merged commit0e4d800 intogithub-tools:masterMar 2, 2020
@alexcanessa
Copy link
Member

That's great, thanks@monicarib

monicaribeiro reacted with thumbs up emoji

@alexcanessa
Copy link
Member

@all-contributors please add@monicarib for code

@allcontributors
Copy link
Contributor

@alexcanessa

I've put upa pull request to add@monicarib! 🎉

monicaribeiro reacted with hooray emoji

@monicaribeiro
Copy link
ContributorAuthor

@alexcanessa thank you!
Could you generate a new release with this update?

@alexcanessa
Copy link
Member

@monicarib yup, will do this evening

@alexcanessa
Copy link
Member

Still some testing happening. Not sure if this is gonna work when no releases are present.

@monicaribeiro
Copy link
ContributorAuthor

monicaribeiro commentedMar 6, 2020
edited
Loading

@alexcanessa do you have a specific scenario? We could add more unit tests to make sure everything is fine.

@JHFarrant
Copy link

@alexcanessa@monicarib Great fix here :)
Do we know when this will be released? Can I help at all with testing?

I thought the whole point is this tool lets us release fast? 😉:trollface:

yogevyuval reacted with thumbs up emoji

@yogevyuval
Copy link

+1 for making a new release so we can use it.
Note: I tried to build it myself with the master, and I get no changelog and it says 0 Pull requests found... Maybe an issue with the current version?
@alexcanessa@monicarib

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alexcanessaalexcanessaAwaiting requested review from alexcanessa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@monicaribeiro@codecov-io@alexcanessa@JHFarrant@yogevyuval

[8]ページ先頭

©2009-2025 Movatter.jp