- Notifications
You must be signed in to change notification settings - Fork318
Replace commit author name with login#175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Replace commit author name with login#175
Uh oh!
There was an error while loading.Please reload this page.
Conversation
GitHub markdown converts @-references with links to user profiles. Usingthe full author name means potentially including a space which breaks thislinking behavior. Instead of the author name (Ex: Mario Tacke), this fixuses the author login (Ex: mariotacke) to form a proper link in therelease notes and changelog).Thisfixesgithub-tools#158
mariotacke commentedJun 16, 2018
The build completed fine on Node 7.9 and 8. The Node 6 runner timed out on TravisCI. Please re-run to get a passing build. |
codecov-io commentedJun 18, 2018
Codecov Report
@@ Coverage Diff @@## master #175 +/- ##===========================================- Coverage 84.34% 38.26% -46.09%=========================================== Files 7 7 Lines 345 345 ===========================================- Hits 291 132 -159- Misses 54 213 +159
Continue to review full report at Codecov.
|
alexcanessa commentedDec 12, 2019
@all-contributors please add@mariotacke for code |
I've put upa pull request to add@mariotacke! 🎉 |
GitHub markdown converts @-references with links to user profiles. Using
the full author name means potentially including a space which breaks this
linking behavior. Instead of the author name (Ex: Mario Tacke), this fix
uses the author login (Ex: mariotacke) to form a proper link in the
release notes and changelog).
Thisfixes#158