Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace commit author name with login#175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mariotacke
Copy link
Contributor

GitHub markdown converts @-references with links to user profiles. Using
the full author name means potentially including a space which breaks this
linking behavior. Instead of the author name (Ex: Mario Tacke), this fix
uses the author login (Ex: mariotacke) to form a proper link in the
release notes and changelog).

Thisfixes#158

alexcanessa and jfix reacted with thumbs up emoji
GitHub markdown converts @-references with links to user profiles. Usingthe full author name means potentially including a space which breaks thislinking behavior. Instead of the author name (Ex: Mario Tacke), this fixuses the author login (Ex: mariotacke) to form a proper link in therelease notes and changelog).Thisfixesgithub-tools#158
@mariotacke
Copy link
ContributorAuthor

The build completed fine on Node 7.9 and 8. The Node 6 runner timed out on TravisCI. Please re-run to get a passing build.

@codecov-io
Copy link

Codecov Report

Merging#175 intomaster willdecrease coverage by46.08%.
The diff coverage is0%.

Impacted file tree graph

@@             Coverage Diff             @@##           master     #175       +/-   ##===========================================- Coverage   84.34%   38.26%   -46.09%===========================================  Files           7        7                 Lines         345      345               ===========================================- Hits          291      132      -159- Misses         54      213      +159
Impacted FilesCoverage Δ
lib/src/Gren.js5.28% <0%> (-75.97%)⬇️
lib/src/GitHubInfo.js80.95% <0%> (-4.77%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec923505...7328564. Read thecomment docs.

@alexcanessaalexcanessa merged commitbeff4c9 intogithub-tools:masterJun 18, 2018
@mariotackemariotacke deleted the fix-158-commit-author-name branchJune 18, 2018 15:18
@alexcanessa
Copy link
Member

@all-contributors please add@mariotacke for code

@allcontributors
Copy link
Contributor

@alexcanessa

I've put upa pull request to add@mariotacke! 🎉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alexcanessaalexcanessaalexcanessa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Commit author's name link is incorrect

3 participants

@mariotacke@codecov-io@alexcanessa

[8]ページ先頭

©2009-2025 Movatter.jp