Use correct param and re-use old attribute to avoid breaking changes#142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

alexcanessa merged 3 commits intogithub-tools:masterfromphun-ky:fix-140

Mar 6, 2018

Merged

Use correct param and re-use old attribute to avoid breaking changes#142

alexcanessa merged 3 commits intogithub-tools:masterfromphun-ky:fix-140

Mar 6, 2018

Conversation

Copy link

phun-ky commentedMar 5, 2018•
edited
Loading

This will fix the previous PR, and properlyfix#140

Alexander Vassbotn Røyne-Helgesen added3 commits

March 1, 2018 13:11

Change url to html_url.Fixes#140

fa87e15

Use correct param, and assign old attribute, so this does not break

0d39254

Merge branch 'master' into fix-140

b69e41d

Copy link

codecov-io commentedMar 6, 2018•
edited
Loading

Codecov Report

Merging#142 intomaster willdecrease coverage by47.36%.
The diff coverage is0%.

@@             Coverage Diff             @@##           master     #142       +/-   ##===========================================- Coverage   86.06%   38.69%   -47.37%===========================================  Files           7        7                 Lines         323      323               ===========================================- Hits          278      125      -153- Misses         45      198      +153

Impacted Files	Coverage Δ
lib/src/Gren.js	`5.69% <0%> (-78.76%)`	⬇️
lib/src/GitHubInfo.js	`80.95% <0%> (-4.77%)`	⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update3f08a6e...b69e41d. Read thecomment docs.