Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix follow and unfollow user#554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@CodyGramlich
Copy link
Contributor

Fixes issue#553.

@j-rewerts
Copy link
Member

@CodyGramlich Could you write some tests that verify the original problem and show how your changes resolve them?
Nice catch though. Surprised this wasn't reported before.

@CodyGramlich
Copy link
ContributorAuthor

CodyGramlich commentedApr 24, 2019
edited
Loading

@j-rewerts Sure, I'll make a test by requesting to follow a user, and then requesting to get the users that I'm following. Then I'll check if the user I tried to follow is in that list. There isn't really an easier way to test it because the response of following yourself is the same response as if you successfully followed someone else.

@CodyGramlich
Copy link
ContributorAuthor

@j-rewerts I added some tests. One of them is to try to follow yourself and show that you're not one of your followers. The previous test does the same thing but for a different user and it shows that you are now following the user.

@j-rewerts
Copy link
Member

Sorry for the delay@CodyGramlich. Could you resolve the conflicts?

@j-rewerts
Copy link
Member

Thanks for the extensive tests! I'm trying out a new review process, so bear with me here.

@j-rewertsj-rewerts changed the base branch frommaster tofollowing-usersJune 17, 2019 20:22
@j-rewertsj-rewerts merged commitb064242 intogithub-tools:following-usersJun 17, 2019
@j-rewertsj-rewerts mentioned this pull requestJun 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CodyGramlich@j-rewerts

[8]ページ先頭

©2009-2025 Movatter.jp