- Notifications
You must be signed in to change notification settings - Fork786
Fix follow and unfollow user#554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix follow and unfollow user#554
Uh oh!
There was an error while loading.Please reload this page.
Conversation
j-rewerts commentedApr 24, 2019
@CodyGramlich Could you write some tests that verify the original problem and show how your changes resolve them? |
CodyGramlich commentedApr 24, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@j-rewerts Sure, I'll make a test by requesting to follow a user, and then requesting to get the users that I'm following. Then I'll check if the user I tried to follow is in that list. There isn't really an easier way to test it because the response of following yourself is the same response as if you successfully followed someone else. |
CodyGramlich commentedMay 2, 2019
@j-rewerts I added some tests. One of them is to try to follow yourself and show that you're not one of your followers. The previous test does the same thing but for a different user and it shows that you are now following the user. |
j-rewerts commentedMay 27, 2019
Sorry for the delay@CodyGramlich. Could you resolve the conflicts? |
j-rewerts commentedJun 17, 2019
Thanks for the extensive tests! I'm trying out a new review process, so bear with me here. |
Fixes issue#553.