- Notifications
You must be signed in to change notification settings - Fork786
Add commit author#547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
j-rewerts commentedApr 6, 2019
j-rewerts commentedApr 9, 2019
@clayreimann Do you want me to merge from upstream master into my branch prior to merging? |
clayreimann commentedApr 9, 2019
@j-rewerts merge or rebase is fine with me. My first instinct is to squash merge for small PRs with more than 1 commit. |
I borrowed this strategy from the writeFile approach.
codecov-io commentedApr 9, 2019
Codecov Report
@@ Coverage Diff @@## master #547 +/- ##========================================= Coverage ? 90.79% ========================================= Files ? 12 Lines ? 413 Branches ? 0 ========================================= Hits ? 375 Misses ? 38 Partials ? 0
Continue to review full report at Codecov.
|
j-rewerts commentedApr 9, 2019
@clayreimann Yeah feel free to squash and merge. |
Closes#546.
The commit function can now accept optional parameters for setting who the author or committer is. Seehere for GitHub's API on it.