- Notifications
You must be signed in to change notification settings - Fork786
refactor: Repository.move filters nodes instead of deleting their sha#355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AurelioDeRosa commentedJun 20, 2016
@clayreimann do you know why the build keeps failing? |
clayreimann commentedJun 20, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
They need better isolation. The tests are pretty fragile, if you look at the build logs for each build that fails they all fail in different ways. Perhaps we just need to slow them down further (maybe 300-400ms between calls), but I think the thing we can do for the tests is to make sure that each test can run independently–so remove cross-test dependencies–and set mocha to retry failed tests a couple times. I've often found that running a build a second time will result in the build passing. Also, we should update |
| returnref; | ||
| }); | ||
| }) | ||
| .filter((ref)=>ref.type!=='tree'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perhaps add whitespace for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure. Where do you want to place it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
between this line and the return
closes#215