Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Identify.pubxml as XML#7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ultraslayyy wants to merge3 commits intogithub-linguist:main
base:main
Choose a base branch
Loading
fromultraslayyy:main

Conversation

@ultraslayyy
Copy link

@ultraslayyyultraslayyy commentedOct 16, 2025•
edited
Loading

Description

Checklist:

@ultraslayyyultraslayyy marked this pull request as ready for reviewOctober 16, 2025 09:41
@ultraslayyyultraslayyy requested a review froma team as acode ownerOctober 16, 2025 09:41
Copy link
Member

@lildudelildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have included a real-world usage sample for all extensions added in this PR:

* Sample source(s):    * https://github.com/ultraslayyy/I-am-bored/blob/info/notepad%23/src/Properties/PublishProfiles/Win64.pubxml (I couldn't find an official Microsoft file on GitHub for this, so I used my own)

You need to add it to the relevant samples directory in this repo.

Any example with an open source license will do.

@ultraslayyy
Copy link
Author

Ok I have done that :)

@lildude
Copy link
Member

A link to your fork of this repo is not the original source. Please update this link to the original source of the sample and state the license (you've deleted thelicense point from the template).

@ultraslayyy
Copy link
Author

I think I fixed it. I'm sorry if I haven't, my brain just isn't at 100% rn :)

@lildude
Copy link
Member

Ooops. I forgot the XML strategy test needs modification too.

You can fix the failing test by adding the sample path to the array in the test:

deftest_xml
no_root_tag=[
"#{samples_path}/XML/libsomething.dll.config",
"#{samples_path}/XML/real-estate.mjml",
"#{samples_path}/XML/XmlIO.pluginspec",
"#{samples_path}/XML/MainView.ux",
"#{samples_path}/XML/MyApp.ux",
"#{samples_path}/XML/xhtml-struct-1.mod",
"#{samples_path}/XML/wixdemo.wixproj",
"#{samples_path}/XML/msbuild-example.proj",
"#{samples_path}/XML/sample.targets",
"#{samples_path}/XML/Default.props",
"#{samples_path}/XML/racoon.mjml",
"#{samples_path}/XML/route-gas-works-lake-union-loop.gpx",
"#{samples_path}/XML/some-ideas.mm",
"#{samples_path}/XML/GMOculus.project.gmx",
"#{samples_path}/XML/obj_control.object.gmx",
"#{samples_path}/XML/MainView.axaml",
"#{samples_path}/XML/Robots.slnx",
]

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lildudelildudeAwaiting requested review from lildude

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ultraslayyy@lildude
[8]ページ先頭
©2009-2025 Movatter.jp