Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork847
Directly handle rate limiting usingclient.rate_limit.resets_in.#967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Directly handle rate limiting usingclient.rate_limit.resets_in.#967
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Ugh I was so curious about the test results, and it was styling issues that stopped the build. I should flip those around, check style after running tests. |
| rescue MovedPermanentlyError => e | ||
| fail_with_message(e, "The repository has moved, update your configuration") | ||
| rescue Octokit::TooManyRequests => e | ||
| resets_in = client.rate_limit.resets_in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🔍 I learned! resets_in (a time) is even provided by Octokit, thanks for finding this out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You are most welcome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 This lets us use Octokit in a more precise way.
Thanks for handling this! |
aelam commentedMay 23, 2022
it seems that It does not work well as before. |
@aelam what is the problem? |
aelam commentedSep 1, 2022
@ioquatix Sorry for late, after I waited a long time, it worked |
We discussed some issues here, and at least when I tried, it, I ran into rate limiting issues.
#965 (comment)
This PR tries to respect GitHub's rate limiting.