Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork848
Ruby 3 support#953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Ruby 3 support#953
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Ah whoops, can't believe I wasted time on this when#949 already exists! |
While I'm here I can report that I updated the GitHub API VCR cassettes and tried out using actual pull_request objects for pull requests instead of issues. The |
@cormacrelf If you want to, you can propose a PR, collecting those thoughts into something everyone can read. I'm only the care-taker. |
@olleolleolle it would just be a PR updating a comment, but sure. |
It was incompatible with Ruby 3 because ofhttps://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
Fixes#952
Fixes#928