Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ruby 3 support#953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

cormacrelf
Copy link

@cormacrelf
Copy link
Author

Ah whoops, can't believe I wasted time on this when#949 already exists!

@cormacrelf
Copy link
Author

While I'm here I can report that I updated the GitHub API VCR cassettes and tried out using actual pull_request objects for pull requests instead of issues. Themerge_commit_sha turns out to be less useful than the comment in generator_fetcher.rb anticipated, as for example withhttps://github.com/github-changelog-generator/changelog_test/pulls/2 themerge_commit_sha points to a commit that no longer exists and this produces incorrect results in various ways. So using the attached events is superior. Hope that helps.

@olleolleolle
Copy link
Collaborator

@cormacrelf If you want to, you can propose a PR, collecting those thoughts into something everyone can read. I'm only the care-taker.

@cormacrelf
Copy link
Author

@olleolleolle it would just be a PR updating a comment, but sure.

olleolleolle reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting an error: 'list_issues': wrong number of arguments (given 3, expected 0..2) (ArgumentError) Add Ruby 3 to CI, make it pass
2 participants
@cormacrelf@olleolleolle

[8]ページ先頭

©2009-2025 Movatter.jp