Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix replicating template messages#794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
olleolleolle merged 7 commits intogithub-changelog-generator:masterfromshinyaohtani:fix/replicating_footer_messages
Apr 15, 2020
Merged

Fix replicating template messages#794

olleolleolle merged 7 commits intogithub-changelog-generator:masterfromshinyaohtani:fix/replicating_footer_messages
Apr 15, 2020

Conversation

shinyaohtani
Copy link
Contributor

@shinyaohtanishinyaohtani commentedApr 13, 2020•
edited by olleolleolle
Loading

Fixes#787

Header, footer and '\n' will be treated correctly

  • Stop generating headers and footers indefinitely, leaving only one right each time.
    • To find the exact same string as the key, the Regex key must be escaped with Regex.escape().
    • Initially I was trying to fix only credit_line. However, I have found that this framework needs to be applied not only to credit_line, but also to headers and front matter, so I modified them with same algorithm correctly.
  • Automatically remove only the automatically added '\n' and not remove any additional '\n' that may have been added manually by the user.
  • specs for this issue is prepared.

Header, footer and '\n' will be treated correctlyIssue:#787- Stop generating headers and footers indefinitely, leaving only one right each time.  - To find the exact same string as the key, the Regex key must be escaped with Regex.escape().  - First I have been fixing only credit_line, but this framework should be applied not only to credit_line but also to header and frontmatter, so I changed header and frontmatter to be deleted once.- Automatically remove only the automatically added '\n' and not remove any additional '\n' that may have been added manually by the user.- specs for this issue is prepared.
@olleolleolle
Copy link
Collaborator

Thanks for this! I'll review soon. 👍

Copy link
Collaborator

@olleolleolleolleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for making this change, it's ✨ !

With a few tiny additions, we can merge it. I marked them with a bunch of GitHub Suggestions (after pulling the PR down to my local machine and running it in different ways).

Thanks!

@olleolleolleolleolleolle changed the titleFixed replicating template messagesFix replicating template messagesApr 14, 2020
shinyaohtaniand others added5 commitsApril 15, 2020 12:10
newer YARD styleCo-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
Content of comment textCo-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
Modified require statements which are automatically added by "rspec-kickstarter"Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
an empty line before expect statementCo-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
an empty line before expect statementCo-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
@shinyaohtani
Copy link
ContributorAuthor

I pressed all "Commit suggestion"s by@olleolleolle.

Copy link
Collaborator

@olleolleolleolleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Alright! Thanks again@shinyaohtani for fixing this issue! ✨

Let's get this merged.

shinyaohtani reacted with hooray emoji
@olleolleolleolleolleolle merged commit2bf0d38 intogithub-changelog-generator:masterApr 15, 2020
@shinyaohtanishinyaohtani deleted the fix/replicating_footer_messages branchApril 15, 2020 06:22
@shinyaohtani
Copy link
ContributorAuthor

shinyaohtani commentedMay 25, 2020•
edited
Loading

@olleolleolle
Could you release a new version including this? I'm waiting...

@shinyaohtani
Copy link
ContributorAuthor

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@olleolleolleolleolleolleolleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer message that keeps replicating
3 participants
@shinyaohtani@olleolleolle@shinya-ohtani
[8]ページ先頭
©2009-2025 Movatter.jp