Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork847
Bugfix: undefined method line_labels_for#753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -40,6 +40,15 @@ def generate_entry_for_tag(pull_requests, issues, newer_tag_name, newer_tag_link | ||
| @content | ||
| end | ||
| def line_labels_for(issue) | ||
olleolleolle marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| labels = if @options[:issue_line_labels] == ["ALL"] | ||
| issue["labels"] | ||
| else | ||
| issue["labels"].select { |label| @options[:issue_line_labels].include?(label["name"]) } | ||
| end | ||
| labels.map { |label| " \[[#{label['name']}](#{label['url'].sub('api.github.com/repos', 'github.com')})\]" }.join("") | ||
| end | ||
| private | ||
| # Creates section objects for this entry. | ||
| @@ -205,14 +214,5 @@ def add_unmapped_section(issues) | ||
| end | ||
| nil | ||
| end | ||
| end | ||
| end | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -7,7 +7,7 @@ module GitHubChangelogGenerator | ||
| # | ||
| # @see GitHubChangelogGenerator::Entry | ||
| class Section | ||
| attr_accessor :name, :options, :prefix, :issues, :labels, :body_only | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. If we're not using the setter, can | ||
| def initialize(opts = {}) | ||
| @name = opts[:name] | ||
| @@ -49,7 +49,7 @@ def get_string_for_issue(issue) | ||
| encapsulated_title = encapsulate_string issue["title"] | ||
| title_with_number = "#{encapsulated_title} [\\##{issue['number']}](#{issue['html_url']})" | ||
| title_with_number = "#{title_with_number}#{Entry.new(options).line_labels_for(issue)}" if @options[:issue_line_labels].present? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Perhaps later, one can build an | ||
| line = issue_line_with_user(title_with_number, issue) | ||
| issue_line_with_body(line, issue) | ||
| end | ||