Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork847
Add no-http-cache option to rake task#739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add no-http-cache option to rake task#739
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi@mcelicalderon! Thanks for your contribution. Would you mind adding a test case? Thanks! |
mcelicalderon commentedOct 7, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sure, I'll get to this as soon as possible. In fact, what would you think about having a constant with all the options available so both the task and binary can use them. That way both will always support the same options. AVAILABLE_OPTIONS={user:{short:'-u',long:'--user USER',description:'Username of the owner of target GitHub repo.'},project:{ ...},token:{ ...}}.freeze and then on the rake task we could just do AVAILABLE_OPTIONS.keys.eachdo and the parser would just use the hash to define options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, it was an oversight, and when we figure out a way to make options generally more shareable, this will go away as a problem.
Simple change to allow to specify the
http_cache
option when using the rake task. This is useful as a workaround for the problem described in#738 but doesn't really fix the issue. Tested locally on my project and it worked.