Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork849
Add Token Location to Verbose Output#1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
olleolleolle merged 4 commits intogithub-changelog-generator:masterfrompseudotsuga-fir:1047-fix-verbose-outputJun 12, 2024
Merged
Add Token Location to Verbose Output#1048
olleolleolle merged 4 commits intogithub-changelog-generator:masterfrompseudotsuga-fir:1047-fix-verbose-outputJun 12, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
olleolleolle approved these changesJun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you,@pseudotsuga-fir!
5b4f473
intogithub-changelog-generator:master 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed issue#1047 where verbose output did not detect when token came from the
CHANGELOG_GITHUB_TOKEN
ENV variable. Updated value to specify if it came from options or ENV vars.How I did it
Added new method
censored_token
tooptions.rb
. Method censors the token by specifying where the token came from, or if it wasn't used.How to verify
:token=>"No token used"
:token=>"Used token from options"
:token=>"Used token from environment variable"
:token=>"Used token from options"