- Notifications
You must be signed in to change notification settings - Fork686
perf: Improve Windows packer examples#4258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
perf: Improve Windows packer examples#4258
Conversation
| description="The instance type Packer will use for the builder" | ||
| type=string | ||
| default="t3a.medium" | ||
| default="c7i-flex.xlarge" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I updated this to a larger instance for better build times. If we'd rather default to smaller in the example, I can replace it.
| launch_block_device_mappings { | ||
| device_name="/dev/sda1" | ||
| volume_size=100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We could leave this parameterized. I've just set this to 100 gigs hardcoded.
All tests passed locally. |
The CI checks for packer are failing. I will mark the PR as draft. Please feel free to mark it ready for review when you are. |
The CI checks are failing on formatting, just do a packer fmt and it should then actually test the changes@iataylor. |
Uh oh!
There was an error while loading.Please reload this page.
Changes made per the issue herehttps://github.com/philips-labs/terraform-aws-github-runner/issues/4248.
That should be most of it.