- Notifications
You must be signed in to change notification settings - Fork218
Bump Node version to v22.21.1#4229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
684ffc4 toab3ef6eCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR updates the Node.js version used for integration tests from v22.20.0 to v22.21.1 to match the Node version in the latest VS Code release. The update is applied consistently across all configuration files.
- Updated Node.js version constraint from ^22.20.0 to ^22.21.1
- Updated @types/node dependency from 22.19.1 to 22.19.2
- Updated .nvmrc to specify v22.21.1
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| extensions/ql-vscode/package.json | Updates Node engine requirement from ^22.20.0 to ^22.21.1 |
| extensions/ql-vscode/package-lock.json | Updates Node engine requirement and @types/node dependency version |
| extensions/ql-vscode/.nvmrc | Updates Node version from v22.20.0 to v22.21.1 for nvm |
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Language not supported
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
| "engines": { | ||
| "vscode":"^1.90.0", | ||
| "node":"^22.20.0", | ||
| "node":"^22.21.1", |
CopilotAIDec 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The PR description contains an error. It states "The previous Node version was v22.20.0. This PR updates the Node version to v22.20.0." Both versions mentioned are the same (v22.20.0), but based on the actual changes in the code, it should read "This PR updates the Node version from v22.20.0 to v22.21.1."
7e15ced to6e237b8Compare6e237b8 toeb2dfe5Compare44529e4 intomainUh oh!
There was an error while loading.Please reload this page.
The Node version used in the latest version of VS Code has been updated. This PR updates the Node version used for integration tests to match.
The previous Node version was v22.20.0. This PR updates the Node version to v22.20.0.