Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update logic for determining list position#32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dgreif merged 1 commit intomainfromupdate-check-for-position
Aug 26, 2022

Conversation

nicolleromero
Copy link
Contributor

@nicolleromeronicolleromero commentedAug 25, 2022•
edited
Loading

Fixeshttps://github.com/github/issues-graph/issues/825

This PR adjusts the logic used to calculate the positioning of lists within a comment to satisfy additionalul andol usage.

See linked issue for additional context.

ims2012035 reacted with thumbs up emojiims2012035 reacted with thumbs down emojiims2012035 reacted with laugh emojiims2012035 reacted with hooray emojiims2012035 reacted with confused emojiims2012035 reacted with heart emojiims2012035 reacted with rocket emojiims2012035 reacted with eyes emoji
@mr-mig
Copy link
Contributor

You may want to double-check these combos:

  • Nested tasklists
  • Nested mixes of checklists and tasklists
  • Tasklists/checklists within HTML tables (not MD tables)
  • Nested tasklists within HTML tables
nicolleromero and ims2012035 reacted with thumbs up emojiims2012035 reacted with thumbs down emojiims2012035 reacted with laugh emojiims2012035 reacted with hooray emojiims2012035 reacted with confused emojiims2012035 reacted with heart emojiims2012035 reacted with rocket emojiims2012035 reacted with eyes emoji

@nicolleromero
Copy link
ContributorAuthor

You may want to double-check these combos:

  • Nested tasklists
  • Nested mixes of checklists and tasklists
  • Tasklists/checklists within HTML tables (not MD tables)
  • Nested tasklists within HTML tables

Tested the above to confirm that no functionality was lost. The current implementation of atasklist remains encapsulated so shouldn't be adversely affected by the new positioning logic when support for nesting w/in tasklists is added. 👍

@nicolleromeronicolleromero marked this pull request as ready for reviewAugust 25, 2022 19:31
@nicolleromeronicolleromero requested a review froma team as acode ownerAugust 25, 2022 19:31
@dgreifdgreif merged commitb4df6e4 intomainAug 26, 2022
@dgreifdgreif deleted the update-check-for-position branchAugust 26, 2022 18:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dgreifdgreifdgreif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@nicolleromero@mr-mig@dgreif
[8]ページ先頭
©2009-2025 Movatter.jp