Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix: Compute the task list item index correctly.#26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
koddsson merged 2 commits intomainfromfix-bug-25
Aug 4, 2021

Conversation

@chanakyabhardwajj
Copy link
Contributor

@chanakyabhardwajjchanakyabhardwajj commentedJul 29, 2021•
edited
Loading

Fixes#25

Problem

If a task list contained elements other than task list items (for example<a>) then the position of the checked/unchecke task list item was being calculated incorrectly.

Fix

The position of a task list item should be computed using only other task list items (and ignoring any other elements).

Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
@chanakyabhardwajj
Copy link
ContributorAuthor

@koddsson Could you please review again?

@chanakyabhardwajjchanakyabhardwajj requested a review froma teamAugust 4, 2021 08:56
@chanakyabhardwajj
Copy link
ContributorAuthor

@github/web-systems-reviewers I would appreciate if you could review this PR.

@koddsson
Copy link
Contributor

Sorry, this wasn't showing up in the first responder queue because the reviewer's team wasn't requested. It is now, but I'll take this on.

Copy link
Contributor

@koddssonkoddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me ✨

@koddssonkoddsson merged commitf802bef intomainAug 4, 2021
@koddssonkoddsson deleted the fix-bug-25 branchAugust 4, 2021 10:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoseInTheArenaJoseInTheArenaAwaiting requested review from JoseInTheArenaJoseInTheArena was automatically assigned from github/web-systems-reviewers

@manuelpuyolmanuelpuyolAwaiting requested review from manuelpuyolmanuelpuyol was automatically assigned from github/web-systems-reviewers

1 more reviewer

@koddssonkoddssonkoddsson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Anchor tag in the markup corrupts the position calculations.

3 participants

@chanakyabhardwajj@koddsson
[8]ページ先頭
©2009-2025 Movatter.jp