Fix ESLint violation#19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

koddsson merged 1 commit intomainfromfix-eslint-violation

May 4, 2021

Merged

Fix ESLint violation#19

koddsson merged 1 commit intomainfromfix-eslint-violation

May 4, 2021

Conversation

Copy link

Contributor

koddsson commentedApr 30, 2021

Use theconnectedCallback function instead of a constructor.

For Custom Elements, the constructor method can be a little unwieldy to use; it is called as soon as the class is instantiated with document.createElement which will be before the element has been appended to the DOM. It can be simpler to put code within the connectedCallback which is fired when the element has been appended into the DOM.

https://github.com/github/eslint-plugin-custom-elements/blob/main/docs/rules/no-constructor.md