The previous PR removed explicit versions for in-repo dependencies. I expected thatcargo publish would just replace thepath dependency with the current version, but instead it complains and aborts.

This PR restores the version numbers where required. (It seems not required for dev dependencies, which I verified using a localcargo publish --dry-run.)

I also removed thepublish-npm workflow job, which would have failed since the NPM package has been removed.

hendrikvanantwerpen added2 commits

July 10, 2024 17:07

Remove NPM publish workflow job

5fcc851

Restore versions for path dependencies, which are required to publish…

9649181

… the crate

hendrikvanantwerpen requested a review froma team as acode owner

July 10, 2024 15:21

hendrikvanantwerpen self-assigned this

Jul 10, 2024

patrickt approved these changes

Jul 10, 2024

View reviewed changes

hendrikvanantwerpen merged commit627e93c intomain

Jul 10, 2024

15 checks passed

hendrikvanantwerpen deleted the remve-npm-action branch

July 10, 2024 15:29

Copy link

github-actionsbot commentedJul 10, 2024

Performance Summary

Comparing basef715ed1 with head9649181 on typescript_benchmark benchmark. For details seeworkflow artifacts.Note that performance is tested on the last commits with changes instack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmarkMassif arguments:   --massif-out-file=perf.outms_print arguments: --x=72 --y=12 base-perf-results/perf.out--------------------------------------------------------------------------------    GB2.275^                                                   #                         |                                                   #                         |                                                  :#                         |                                               @@@:#                         |                                               @  :#                         |                                               @  :#                         |                                             ::@  :#                ::::     |                                            :: @  :#                :: :     |                                            :: @  :#                :: :     |                                     @@  ::::: @  :#       ::   :::::: :     |                     @@  @@         :@@: :: :: @  :#      ::: : ::  :: :     |                     @@::@@: ::    ::@@:::: :: @  :#     ::::@::::  :: :   0 +----------------------------------------------------------------------->Gi     0                                                                   87.72

After

--------------------------------------------------------------------------------Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmarkMassif arguments:   --massif-out-file=perf.outms_print arguments: --x=72 --y=12 head-perf-results/perf.out--------------------------------------------------------------------------------    GB2.275^                                                  #                          |                                                  #                          |                                                 :#                          |                                              @@@:#                          |                                              @  :#                  :::     |                                              @  :#                  : :     |                                            ::@  :#                ::: :     |                                           :: @  :#                : : :     |                                           :: @  :#                : : :     |                                     @  ::::: @  :#       ::  :::::: : :     |                         :         ::@ ::: :: @  :#      ::: :::   : : :     |                    @::::: : ::   :::@:::: :: @  :#     ::::@:::   : : :   0 +----------------------------------------------------------------------->Gi     0                                                                   89.70