Commit8c70def

jhawthorn

and

luke-gru

committed

Use ALWAYS_INLINE for vm_getinstancevariable

Recently rb_vm_getinstancevariable was introduced exposing this methodto ZJIT. On clang specifically this ended up causing the compiler not toinline into vm_exec_core and cause a significant performance regressionin optcarrot for the interpreter.Co-authored-by: Luke Gruber <luke.gru@gmail.com>

1 parent191bfcb commit8c70defCopy full SHA for 8c70def

File tree

1 file changed

-0

lines changed

vm_insnhelper.c

1 file changed

-0

lines changed

`‎vm_insnhelper.c‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1680,6 +1680,7 @@ rb_vm_setclassvariable(const rb_iseq_t iseq, const rb_control_frame_t cfp, ID`
`1680`	`1680`	`vm_setclassvariable(iseq,cfp,id,val,ic);`
`1681`	`1681`	`}`
`1682`	`1682`
	`1683`	`+ALWAYS_INLINE(staticVALUEvm_getinstancevariable(constrb_iseq_t*iseq,VALUEobj,IDid,IVCic));`
`1683`	`1684`	`staticinlineVALUE`
`1684`	`1685`	`vm_getinstancevariable(constrb_iseq_t*iseq,VALUEobj,IDid,IVCic)`
`1685`	`1686`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8c70def

File tree

1 file changed

1 file changed

`‎vm_insnhelper.c‎`

0 commit comments