Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix deprecated Naming/PredicateName cop - rename to Naming/PredicatePrefix#312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
peter-evans merged 4 commits intomainfromcopilot/fix-311
Jun 9, 2025

Conversation

Copilot
Copy link
Contributor

@CopilotCopilotAI commentedJun 5, 2025•
edited
Loading

TheNaming/PredicateName cop has been renamed toNaming/PredicatePrefix in RuboCop 1.76.0, causing deprecation warnings when using this gem:

Warning: The `Naming/PredicateName` cop has been renamed to `Naming/PredicatePrefix`.(obsolete configuration found in config/default.yml, please update it)

This PR updates the configuration to use the new cop name and bumps the minimum RuboCop version to 1.76 to ensure compatibility.

Changes:

  • RenamedNaming/PredicateName toNaming/PredicatePrefix inconfig/default.yml
  • Updated RuboCop dependency from>= 1.72 to>= 1.76 in gemspec
  • Addedvendor/ to.gitignore to prevent bundled gems from being committed

Verification:

  • All existing tests pass (114 runs, 164 assertions, 0 failures)
  • RuboCop runs without deprecation warnings on version 1.76.0
  • All files pass style checks with no offenses

Fixes#311.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.

CopilotAIand others added2 commitsJune 5, 2025 23:10
Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
…refixCo-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
Copy link

@github-advanced-securitygithub-advanced-securitybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check theFiles changed tab for more details.

@CopilotCopilotAI changed the title[WIP] Getting warnings from deprecated Naming/PredicateNameFix deprecated Naming/PredicateName cop - rename to Naming/PredicatePrefixJun 5, 2025
@CopilotCopilotAI requested a review fromjonrohanJune 5, 2025 23:17
Copilot finished work on behalf ofjonrohanJune 5, 2025 23:17
@jonrohan
Copy link
Member

@copilot can you re-examine the original issue and recreate this pull request?

Copilot finished work on behalf ofjonrohanJune 5, 2025 23:20
@jonrohan
Copy link
Member

@copilot Remove the vendor folder checked into this pull request

Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
@CopilotCopilot SWE Agent
Copy link
ContributorAuthor

CopilotAI commentedJun 5, 2025

@copilot Remove the vendor folder checked into this pull request

The vendor folder has been removed from the repository. Commit9ba2d39 removes all the bundled gems that were accidentally committed while keeping the vendor/ entry in .gitignore to prevent future accidents.

@jonrohanjonrohan marked this pull request as ready for reviewJune 5, 2025 23:27
@jonrohanjonrohan requested a review froma team as acode ownerJune 5, 2025 23:27
Copilot finished work on behalf ofjonrohanJune 5, 2025 23:27
@jonrohanjonrohan requested a review fromissyl0June 5, 2025 23:41
Copy link
Member

@peter-evanspeter-evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@peter-evanspeter-evans merged commitc57fc62 intomainJun 9, 2025
10 checks passed
@peter-evanspeter-evans deleted the copilot/fix-311 branchJune 9, 2025 08:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@peter-evanspeter-evanspeter-evans approved these changes

@jonrohanjonrohanAwaiting requested review from jonrohan

@issyl0issyl0Awaiting requested review from issyl0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TheNaming/PredicateName cop has been renamed toNaming/PredicatePrefix.
3 participants
@Copilot@jonrohan@peter-evans
[8]ページ先頭
©2009-2025 Movatter.jp