Commitc8eaba8

khiga8

and

keithamus

committed

Remove quote-selection event

This was only used to intercept quote behaviour, and doesn't really addany value as whatever used to listen to this can simply do the samebehaviour after `quote()` has been called.Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>

1 parentab12699 commitc8eaba8Copy full SHA for c8eaba8

File tree

3 files changed

-38

lines changed

3 files changed

-38

lines changed

`‎README.md‎`

Lines changed: 0 additions & 14 deletions

Original file line number	Diff line number	Diff line change
@@ -44,21 +44,7 @@ The optional `scopeSelector` parameter ensures that even if the user selection b
`44`	`44`	`##Events`
`45`	`45`
`46`	`46`	-`quote-selection-markdown` (bubbles: true, cancelable: false) - fired on the quote region to optionally inject custom syntax into the`fragment` element in`quoteMarkdown: true` mode
`47`		--`quote-selection` (bubbles: true, cancelable: true) - fired on the quote region before text is appended to a textarea
`48`	`47`
`49`		`-For example, reveal a textarea so it can be found:`
`50`		`-`
`51`		-```js
`52`		`-region.addEventListener('quote-selection',function (event) {`
`53`		`-const {selection,selectionText}=event.detail`
`54`		`-console.log('Quoted text', selection, selectionText)`
`55`		`-`
`56`		`-consttextarea=event.target.querySelector('textarea')`
`57`		`-textarea.hidden=false`
`58`		`-`
`59`		`-// Cancel the quote behavior.`
`60`		`-// event.preventDefault()`
`61`		`-})`
`62`	`48`	```
`63`	`49`
`64`	`50`	`## Development`

`‎src/index.ts‎`

Lines changed: 0 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,19 +34,6 @@ export function quote(selectionContext: SelectionContext, options: Partial<Optio`
`34`	`34`	`if(!quoted)returnfalse`
`35`	`35`
`36`	`36`	`const{container, selectionText}=quoted`
`37`		`-`
`38`		`-constdispatched=container.dispatchEvent(`
`39`		`-newCustomEvent('quote-selection',{`
`40`		`-bubbles:true,`
`41`		`-cancelable:true,`
`42`		`-detail:{range:selectionContext.range, selectionText}`
`43`		`-})`
`44`		`-)`
`45`		`-`
`46`		`-if(!dispatched){`
`47`		`-returntrue`
`48`		`-}`
`49`		`-`
`50`	`37`	`constfield=findTextarea(container)`
`51`	`38`	`if(!field)returnfalse`
`52`	`39`

`‎test/test.js‎`

Lines changed: 1 addition & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,36 +33,26 @@ describe('quote-selection', function () {`
`33`	`33`	`constselection=window.getSelection()`
`34`	`34`	`window.getSelection=()=>createSelection(selection,el)`
`35`	`35`
`36`		`-constcontainer=document.querySelector('[data-quote]')`
`37`	`36`	`consttextarea=document.querySelector('#not-hidden-textarea')`
`38`		`-leteventCount=0`
`39`	`37`	`letchangeCount=0`
`40`	`38`
`41`		`-container.addEventListener('quote-selection',function(){`
`42`		`-eventCount++`
`43`		`-})`
`44`		`-`
`45`	`39`	`textarea.addEventListener('change',function(){`
`46`	`40`	`changeCount++`
`47`	`41`	`})`
`48`	`42`
`49`	`43`	`quote(getSelectionContext(),{containerSelector:'[data-quote], [data-nested-quote]'})`
`50`	`44`	`assert.equal(textarea.value,'Has text\n\n> Test Quotable text, bold.\n\n')`
`51`		`-assert.equal(eventCount,1)`
`52`	`45`	`assert.equal(changeCount,1)`
`53`	`46`	`})`
`54`	`47`
`55`	`48`	`it('nested textarea is updated when event is captured',function(){`
`56`	`49`	`constel=document.querySelector('#nested-quotable')`
`57`	`50`	`constselection=window.getSelection()`
`58`	`51`	`window.getSelection=()=>createSelection(selection,el)`
`59`		`-constcontainer=document.querySelector('[data-nested-quote]')`
`60`	`52`	`consttextarea=document.querySelector('#nested-textarea')`
`61`	`53`	`constouterTextarea=document.querySelector('#not-hidden-textarea')`
`62`	`54`
`63`		`-container.addEventListener('quote-selection',function(){`
`64`		`-textarea.hidden=false`
`65`		`-})`
	`55`	`+textarea.hidden=false`
`66`	`56`
`67`	`57`	`quote(getSelectionContext(),{containerSelector:'[data-quote], [data-nested-quote]'})`
`68`	`58`	`assert.equal(outerTextarea.value,'Has text')`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc8eaba8

File tree

3 files changed

3 files changed

`‎README.md‎`

`‎src/index.ts‎`

`‎test/test.js‎`

0 commit comments