Commitad0e6d0

keithamus

and

khiga8

committed

SimplifyextractQuote options.

BREAKING CHANGEThis function only ever used the `quoteElement` option, so it issimpler to have this as an optional argument as opposed to having anoptions object passed in.Co-authored-by: Kate Higa <khiga8@github.com>

1 parent42a3444 commitad0e6d0Copy full SHA for ad0e6d0

File tree

2 files changed

-15

lines changed

src
- index.ts
test
- test.js

2 files changed

-15

lines changed

`‎src/index.ts‎`

Lines changed: 3 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,23 +1,17 @@`
`1`	`1`	`import{extractFragment,insertMarkdownSyntax}from'./markdown'`
`2`	`2`
`3`		`-typeOptions={`
`4`		`-quoteMarkdown:boolean`
`5`		`-scopeSelector:string`
`6`		`-quoteElement:Element`
`7`		`-}`
`8`		`-`
`9`	`3`	`typeQuote={`
`10`	`4`	`container:Element`
`11`	`5`	`range:Range`
`12`	`6`	`selectionText:string`
`13`	`7`	`}`
`14`	`8`
`15`		`-exportfunctionextractQuote(containerSelector:string,options?:Partial<Options>):Quote\|undefined{`
	`9`	`+exportfunctionextractQuote(containerSelector:string,quoteElement?:Element):Quote\|undefined{`
`16`	`10`	`constselection=window.getSelection()`
`17`	`11`	`if(!selection)return`
`18`		`-if(options?.quoteElement){`
	`12`	`+if(quoteElement){`
`19`	`13`	`selection.removeAllRanges()`
`20`		`-selection.selectAllChildren(options.quoteElement)`
	`14`	`+selection.selectAllChildren(quoteElement)`
`21`	`15`	`}`
`22`	`16`	`letrange`
`23`	`17`	`try{`

`‎test/test.js‎`

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -98,9 +98,7 @@ describe('quote-selection', function () {`
`98`	`98`	`})`
`99`	`99`
`100`	`100`	`it('preserves formatting',function(){`
`101`		`-constquote=extractQuote('[data-quote]',{`
`102`		`-quoteElement:document.querySelector('.comment-body')`
`103`		`-})`
	`101`	`+constquote=extractQuote('[data-quote]',document.querySelector('.comment-body'))`
`104`	`102`	`constmarkdownQuote=asMarkdown(quote,'.comment-body')`
`105`	`103`
`106`	`104`	`consttextarea=document.querySelector('textarea')`
`@@ -127,9 +125,7 @@ describe('quote-selection', function () {`
`127`	`125`	`})`
`128`	`126`
`129`	`127`	`it('provides a callback to mutate markup',function(){`
`130`		`-constquote=extractQuote('[data-quote]',{`
`131`		`-quoteElement:document.querySelector('.comment-body')`
`132`		`-})`
	`128`	`+constquote=extractQuote('[data-quote]',document.querySelector('.comment-body'))`
`133`	`129`	`constmarkdownQuote=asMarkdown(quote,'.comment-body',fragment=>{`
`134`	`130`	`fragment.querySelector('a[href]').replaceWith('@links')`
`135`	`131`	`fragment.querySelector('img[alt]').replaceWith(':emoji:')`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitad0e6d0

File tree

2 files changed

2 files changed

`‎src/index.ts‎`

`‎test/test.js‎`

0 commit comments