- Notifications
You must be signed in to change notification settings - Fork8
Return consistent promise object for repeated calls with the same key#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
14 commits Select commitHold shift + click to select a range
3d5643a
cache wrapped promise instead of inner one
akennethf502961
update test
akenneth6c263e3
Remove whitespaces
akennethe9ca211
remove whitespace from test/index.ts
akennethdef7948
style: eslint --fix
keithamus46a0ed2
test: separate assertions, avoid using `eql` which does deep equality…
keithamus317af21
test: switch to async/await
keithamus963f8df
chore: drop chai-as-promised
keithamus0e75414
style: eslint --fix
keithamus842623a
refactor: simplify promise case
keithamus36dbf01
Only spy on `set`
koddssonfa41069
test: isolate test for Promise referential equality
keithamus52ca6ad
test: add test to ensure Promise is not caught in side channel
keithamus1cf023a
test: remove redundant test for Promise ordering
keithamusFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PrevPrevious commit
test: remove redundant test for Promise ordering
The earlier test which affirms Promise equality with subsequent callsguarantees the behavior of sequential ordering as per the spec. It ispointless to test this as if the test breaks it is a bug with the JSengine and one we're unlikely able to fix (or is at least out of thescope of this project). Our interest is only in the earlier test ofreferential equality.This test also tests the cache implementation, but this is needless asthere are other tests which affirm these semantics.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit1cf023a8b3e80ae363d3a554301012660475a416
There are no files selected for viewing
46 changes: 0 additions & 46 deletionstest/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.