NotificationsYou must be signed in to change notification settings
Fork8
Star31

allow for customising of the hash return type as`H`#12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

srt32 merged 2 commits intogithub:mainfromkeithamus:patch-1

Apr 17, 2023

Merged

allow for customising of the hash return type as`H`#12

srt32 merged 2 commits intogithub:mainfromkeithamus:patch-1

Apr 17, 2023

Conversation

Copy link

Contributor

keithamus commentedMar 27, 2023

This should allow for the hashing return type to be properly typed by an implementation.

allow for customising of the hash return type asH

f7e6128

keithamus requested a review froma team as acode owner

March 27, 2023 17:02

keithamus requested a review fromsrt32

March 27, 2023 17:02

accidentally a line

e6355fb

Copy link

ContributorAuthor

keithamus commentedApr 17, 2023

@srt32 would you kindly take a look at this

Copy link

JnBrymn commentedApr 17, 2023

To add some context. I'm working on a copilot PR and we would like to use an LRUCache implementation for the memoization cache. There's already an LRUCache implementation present within copilot, but w/o this change we're forced to create a wrapper for it because it can't be used directly. It would be nice to just usememoize w/o having to make redundant wrapper code.