- Notifications
You must be signed in to change notification settings - Fork5
Update and add more test coverage forno-default-alt-text#84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!@khiga8, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text atBasic writing and formatting syntax: images on GitHub Docs. |
1 similar comment
Uh oh!@khiga8, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text atBasic writing and formatting syntax: images on GitHub Docs. |
Uh oh!@khiga8, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text atBasic writing and formatting syntax: images on GitHub Docs. |
no-alt-textno-default-alt-textUh oh!@khiga8, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text atBasic writing and formatting syntax: images on GitHub Docs. |
1 similar comment
Uh oh!@khiga8, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text atBasic writing and formatting syntax: images on GitHub Docs. |
no-default-alt-textno-default-alt-textUh oh!@khiga8, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text atBasic writing and formatting syntax: images on GitHub Docs. |
Uh oh!
There was an error while loading.Please reload this page.
In#83, we refactored the rule so we don't rely entirely on Regex for parsing, which was causing the rule to flag images within code blocks. (Edit: Like#84 (comment))
This is a follow-up to that change. I noticed the rule was not correctly flagging the case where there are two images like so:
This PR makes a few updates:
detailto include the alt that is being flagged.