Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve the no-default-alt-text rule#40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iansan5653 merged 5 commits intomainfromimprove-no-default-alt-text
Apr 26, 2023

Conversation

iansan5653
Copy link
Member

@iansan5653iansan5653 commentedApr 21, 2023
edited
Loading

Contains a few improvements to rough edges around theno-default-alt-text rule that I noticed while working on myMarkdown checker browser extension:

  • Made the description more succinct: "Images should have meaningful alternative text (alt text)" instead of "Images should set meaningful alternative text (alt text), and not use the macOS default screenshot filename orImage." This shorter description is consistent with the default Markdownlint rules
  • Removed thedetail field from failures, since it was just a copy of the image's alt text. This was distracting and not very helpful - the detail field is only really useful for showing hints on how to resolve the issue. For example, a useful detail forMD001 looks like: "Expected: h2; Actual: h3"
  • Added arange field that only covers the alt text so we don't have to error the entire line. This helps draw attention to the specific issue at hand and helps writers figure out specifically where to put better alt text. This required using regular expressions for all checking (instead of only for HTML), because the default Markdown parser tokens don't have ranges

Note: The use of thed flag in the regular expressions (which is necessary in order to get the range indexes) means we can only now support later versions of Node since this is an ES2022 feature.

@iansan5653iansan5653 requested a review froma team as acode ownerApril 21, 2023 16:02
@accessibility-bot
Copy link
Collaborator

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos (with description following) demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️If this is urgent, please visit us in#accessibility on Slack and tag the first responder(s) listed in the channel topic.

Copy link
Contributor

@lindseywildlindseywild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this!

@iansan5653iansan5653 merged commit114f037 intomainApr 26, 2023
@iansan5653iansan5653 deleted the improve-no-default-alt-text branchApril 26, 2023 15:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lindseywildlindseywildlindseywild approved these changes

@accessibility-botaccessibility-botAwaiting requested review from accessibility-botaccessibility-bot is a code owner automatically assigned from github/accessibility

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@iansan5653@accessibility-bot@lindseywild

[8]ページ先頭

©2009-2025 Movatter.jp