- Notifications
You must be signed in to change notification settings - Fork5
chore(deps-dev): bump markdownlint from 0.36.1 to 0.37.3#135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Bumps [markdownlint](https://github.com/DavidAnson/markdownlint) from 0.36.1 to 0.37.3.- [Changelog](https://github.com/DavidAnson/markdownlint/blob/main/CHANGELOG.md)- [Commits](DavidAnson/markdownlint@v0.36.1...v0.37.3)---updated-dependencies:- dependency-name: markdownlint dependency-type: direct:development update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>
index.js Outdated
| return foo; | ||
| } | ||
| // export default githubMarkdownLint; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can't seem to export destructures in ESM, static vs dynamic?
Uh oh!
There was an error while loading.Please reload this page.
| @@ -1,19 +1,20 @@ | |||
| const _= require("lodash"); | |||
| import _from"lodash-es"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
regular lodash is synchronous
package.json Outdated
| "directories": { | ||
| "test": "test" | ||
| }, | ||
| "scripts": { | ||
| "publish": "npm publish --access public --@github:registry=https://registry.npmjs.org", | ||
| "test": "npm run lint && jest", | ||
| "test": "NODE_OPTIONS=--experimental-vm-modules jest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
jest needs this to enable ESM
package.json Outdated
| "markdownlint": "^0.36.1", | ||
| "markdownlint-cli2": "^0.16.0" | ||
| "markdownlint": "^0.37.3", | ||
| "markdownlint-cli2": "^0.17.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
cli2 previous version seemed incompatible w/newmarkdownlint
Uh oh!
There was an error while loading.Please reload this page.
| @@ -1,6 +1,6 @@ | |||
| const markdownlint = require("markdownlint"); | |||
| import { lint } from"markdownlint/async"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
needs new function now
lindseywild commentedJan 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@JoyceZhu should I remove this from the FR queue until you're ready for a review? Or is there anything I can do to assist? |
A newer version of markdownlint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice job! I didn't see anything glaring, and old files seemed to be migrated properly from what I can tell!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looking good! Thank you for your persistence on this!
I just had a few questions :)
test/accessibility-rules.test.js Outdated
| "no-generic-link-text": true, | ||
| "ul-style": { | ||
| style: "asterisk", | ||
| }, | ||
| default: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Doesdefault: false turn off all the rules by default-enabled rules?
I'm wondering why we need to explicitly set individual rules tofalse ifdefault: false.
| @@ -0,0 +1,15 @@ | |||
| import { init } from "./index.js"; | |||
| const configOptions = await init({ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was about to recommend pointing of our projects to this branch to make sure things run as expected with this big change/new setup, but it seems like this basically acts like a test? Would it be worth testing this change out in one of our larger repos that uses this project by pointing to this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, my understanding after reading for awhile is that we only have this file/usemarkdownlint-cli2 so we canrun our own linting setup against the files in this repo (meta-testing, I guess).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice work 💟
021ee10 to3ae5b70Compare607c420 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Changes included (from@JoyceZhu):
READMEto use ESM syntax/examplespackage.jsonchanges for ESMeslintconfig changes to respect that ESM imports need to reference the file extension in the path without further worklodash-essince the originallodashlibrary is CommonJS-onlymarkdownlint-cli2calls to newasyncimplementations.nvmrcsince I was already hereJSONfiles -- convert those to manual file readsBumpsmarkdownlint from 0.36.1 to 0.37.3.
Changelog
Sourced frommarkdownlint's changelog.
Commits
74b1c19Update to version 0.37.3.ef70472Make micromark-core-commonmark a direct dependency to satisfy strict dependen...795eac2Add CI job that verifies tests pass when using pnpm (vs. npm).df33933Update export test to avoid "ExperimentalWarning: Importing JSON modules is a...8e5f699Bump webpack-cli from 6.0.0 to 6.0.192eb425Bump eslint-plugin-n from 17.15.0 to 17.15.11587927Bump webpack-cli from 5.1.4 to 6.0.0a1081ecAdd "bundler" and "subpath" to dictionary.txt.5fad452Update to version 0.37.2.baf4944Add subpath imports "markdownlint-imports-browser" and "markdownlint-imports-...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)