Commit9ba0286

authored

Chore: cleanup redundant alt attribute check (#101)

* chore: Remove check for no alt attribute* Remove code comment* Update test

1 parentadd9f62 commit9ba0286Copy full SHA for 9ba0286

File tree

-14

lines changed

-14

lines changed

Lines changed: 0 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-// TODO: Clean up when https://github.com/DavidAnson/markdownlint/pull/993 is merged`
`2`	`1`	`module.exports={`
`3`	`2`	`names:["GH003","no-empty-alt-text"],`
`4`	`3`	`description:"Please provide an alternative text for the image.",`
`@@ -19,7 +18,6 @@ module.exports = {`
`19`	`18`	`);`
`20`	`19`
`21`	`20`	`constImageRegex=newRegExp(/<img(.*?)>/,"gid");`
`22`		`-consthtmlAltRegex=newRegExp(/alt=['"]/,"gid");`
`23`	`21`	`consthtmlEmptyAltRegex=newRegExp(/alt=['"]['"]/,"gid");`
`24`	`22`	`for(consttokenofhtmlTagsWithImages){`
`25`	`23`	`constlineRange=token.map;`
`@@ -35,20 +33,13 @@ module.exports = {`
`35`	`33`	`constemptyAltMatches=[`
`36`	`34`	`...imageTag[0].matchAll(htmlEmptyAltRegex),`
`37`	`35`	`][0];`
`38`		`-constnoAltMatches=[...imageTag[0].matchAll(htmlAltRegex)];`
`39`		`-`
`40`	`36`	`if(emptyAltMatches){`
`41`	`37`	`constmatchingContent=emptyAltMatches[0];`
`42`	`38`	`conststartIndex=emptyAltMatches.indices[0][0];`
`43`	`39`	`onError({`
`44`	`40`	`lineNumber:lineNumber+i,`
`45`	`41`	`range:[imageTagIndex+startIndex+1,matchingContent.length],`
`46`	`42`	`});`
`47`		`-}elseif(noAltMatches.length===0){`
`48`		`-onError({`
`49`		`-lineNumber:lineNumber+i,`
`50`		`-range:[imageTagIndex+1,imageTag[0].length],`
`51`		`-});`
`52`	`43`	`}`
`53`	`44`	`}`
`54`	`45`	`}`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,19 +19,15 @@ describe("GH003: No Empty Alt Text", () => {`
`19`	`19`	`'<img alt="" src="https://user-images.githubusercontent.com/abcdef.png">',`
`20`	`20`	`"<img alt='' src='https://user-images.githubusercontent.com/abcdef.png'>",`
`21`	`21`	`'<img src="cat.png" alt="" /> <img src="dog.png" alt="" />',`
`22`		`-'<img src="dog.png" />',`
`23`		`-'<img alt src="dog.png" />',`
`24`		`-"<img alt><img alt>",`
`25`	`22`	`];`
`26`	`23`
`27`	`24`	`constresults=awaitrunTest(strings,noEmptyStringAltRule);`
`28`		`-`
`29`	`25`	`constfailedRules=results`
`30`	`26`	`.map((result)=>result.ruleNames)`
`31`	`27`	`.flat()`
`32`	`28`	`.filter((name)=>!name.includes("GH"));`
`33`	`29`
`34`		`-expect(failedRules).toHaveLength(8);`
	`30`	`+expect(failedRules).toHaveLength(4);`
`35`	`31`	`for(construleoffailedRules){`
`36`	`32`	`expect(rule).toBe("no-empty-alt-text");`
`37`	`33`	`}`

Comments

(0)