Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add HIDE_ITEMS_LIST environment variable to hide individual items table in reports#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zkoppert merged 8 commits intomainfromcopilot/add-env-var-for-report
Oct 7, 2025

Conversation

Copy link
Contributor

CopilotAI commentedOct 4, 2025
edited
Loading

Add HIDE_ITEMS_LIST environment variable to hide issue/PR details table

Summary

Successfully implemented a new environment variableHIDE_ITEMS_LIST that allows users to hide the individual items table in the generated report while keeping all summary metrics visible. This addresses the feature request to provide management with only aggregated metrics without the detailed list of issues/PRs.

Implementation Checklist

  • Add newhide_items_list boolean attribute toEnvVars class inconfig.py
  • ReadHIDE_ITEMS_LIST environment variable inget_env_vars() function (default to False for backward compatibility)
  • UpdateEnvVars.__init__() to accepthide_items_list parameter
  • UpdateEnvVars.__repr__() to includehide_items_list
  • Modifywrite_to_markdown() inmarkdown_writer.py to conditionally skip writing the items table whenhide_items_list is True
  • Add comprehensive tests for the new functionality
  • UpdateREADME.md to document the new environment variable
  • Run linting and tests to validate changes
  • Manually verify the implementation works correctly
  • Request and address code review feedback
  • Run prettier on markdown files to fix linting issues

Test Results

✅ All 135 tests pass (up from 133 - added 2 new tests)
✅ Code coverage: 91.42%
✅ Linting: 10.00/10 rating
✅ Manual testing verified correct behavior
✅ Prettier formatting applied to all markdown files

Behavior

  • Default (HIDE_ITEMS_LIST=false): Shows summary metrics + count table + individual items table
  • When HIDE_ITEMS_LIST=true: Shows summary metrics + count table only (items table is hidden)

Backward Compatibility

The default value isfalse, ensuring all existing workflows continue to work without any changes. Users must explicitly setHIDE_ITEMS_LIST=true to hide the items list.

Original prompt

This section details on the original issue you should resolve

<issue_title>Add env_var to include issue/PR list in the report</issue_title>
<issue_description>### Is your feature request related to a problem?

Right now, Managment only wants to view the statistics and not the details of the report. So, they're not interesested in the list of PRs involved in the metrics.

Describe the solution you'd like

Right now, by default, the list of issues or PRs is included in the report, with no option to exclude it.

It would be ideal to have a new environment variable, maybe called HIDE_ISSUE_LIST (or similar), set to "false" by default (to respect backwards compatibility), to choose if the Issue list should be included in the report or not.
If this new environment variable is set to "true", then report would only include aggregated metrics, like in the following image:

Image

Describe alternatives you've considered

I have considered the possibility of altering the report file once created, to remove the last table, containing the issue list. But for the sake of maintainability, it would be ideal to have this feature as part of the GH Action.

Additional context

None.</issue_description>

Comments on the Issue (you are@copilot in this section)

Fixes#609

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.

Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>
CopilotAI changed the title[WIP] Add environment variable to exclude issue list from reportsAdd HIDE_ITEMS_LIST environment variable to hide individual items table in reportsOct 4, 2025
CopilotAI requested a review fromzkoppertOctober 4, 2025 22:19
Copilot finished work on behalf ofzkoppertOctober 4, 2025 22:19
@zkoppert
Copy link
Member

@copilot please run prettier on the markdown files to fix the linting issues

@zkoppertzkoppert changed the titleAdd HIDE_ITEMS_LIST environment variable to hide individual items table in reportsfeat: Add HIDE_ITEMS_LIST environment variable to hide individual items table in reportsOct 6, 2025
Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>
Copy link
ContributorAuthor

CopilotAI commentedOct 6, 2025

@copilot please run prettier on the markdown files to fix the linting issues

Done! Ran prettier on README.md and fixed the trailing whitespace issue. All markdown files now pass prettier formatting checks.

Copilot finished work on behalf ofzkoppertOctober 6, 2025 17:59
@zkoppertzkoppert marked this pull request as ready for reviewOctober 6, 2025 19:27
@zkoppertzkoppert requested a review froma team as acode ownerOctober 6, 2025 19:27
CopilotAI review requested due to automatic review settingsOctober 6, 2025 19:27
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds a new environment variableHIDE_ITEMS_LIST that allows users to hide the individual items table in the generated report while keeping all summary metrics visible. This addresses management's need to view only aggregated metrics without detailed issue/PR listings.

  • AddHIDE_ITEMS_LIST environment variable with default value offalse for backward compatibility
  • Conditionally skip rendering the individual items table when the variable is set totrue
  • Add comprehensive tests and update documentation

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
config.pyAdds the newhide_items_list boolean attribute toEnvVars class and environment variable reading logic
markdown_writer.pyImplements conditional logic to skip writing the items table whenhide_items_list is True
test_config.pyAdds test to verify the new environment variable is properly read and updates existing test expectations
test_markdown_writer.pyAdds comprehensive test to verify the items table is hidden whenHIDE_ITEMS_LIST=true
README.mdDocuments the new environment variable with description and default value

zkoppertand others added3 commitsOctober 6, 2025 12:29
Signed-off-by: Zack Koppert <zkoppert@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>Signed-off-by: Zack Koppert <zkoppert@github.com>
Copy link
Member

@zkoppertzkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tested locally! Works great!

Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppertzkoppert merged commit17c6bd1 intomainOct 7, 2025
34 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@jmeridthjmeridthjmeridth approved these changes

+1 more reviewer

@zkoppertzkoppertzkoppert approved these changes

Reviewers whose approvals may not affect merge requirements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add env_var to include issue/PR list in the report

3 participants

@zkoppert@jmeridth

[8]ページ先頭

©2009-2025 Movatter.jp