Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: go back to using root user in Dockerfile#600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jmeridth merged 1 commit intomainfromjm_fix_github_output_permissions
Sep 18, 2025

Conversation

@jmeridth
Copy link
Member

@jmeridthjmeridth commentedSep 18, 2025•
edited
Loading

Fixes#598

Pull Request

Proposed Changes

We have to do this because we have no active way to change permissions to $GITHUB_OUTPUT to a specific user when running the container

Add trivy ignore to top of Dockerfile to pass linting

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • runmake lint and fix any issues that you have introduced
  • runmake test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from@jeffrey-luszcz

Reviewer

  • Label as eitherfix,documentation,enhancement,infrastructure,maintenance, orbreaking

We have to do this because we have no active way to changepermissions to $GITHUB_OUTPUT to a specific user whenrunning the containerAdd trivy ignore to top of Dockerfile to pass lintingSigned-off-by: jmeridth <jmeridth@gmail.com>
@jmeridthjmeridth self-assigned thisSep 18, 2025
@jmeridthjmeridth requested a review froma team as acode ownerSeptember 18, 2025 03:08
CopilotAI review requested due to automatic review settingsSeptember 18, 2025 03:08
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR reverts the Dockerfile back to using the root user instead of a non-root user due to permission issues with writing to$GITHUB_OUTPUT when running in a container environment. The change removes the user creation and switching logic while adding a trivy security scanner ignore directive.

  • Removes non-root user creation and switching to resolve GitHub Actions output permission issues
  • Adds trivy ignore directive to suppress security warnings about running as root
  • Simplifies the Dockerfile by removing user management complexity

@jmeridthjmeridth merged commitc2ad23c intomainSep 18, 2025
36 checks passed
@jmeridthjmeridth deleted the jm_fix_github_output_permissions branchSeptember 18, 2025 03:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

@jmeridthjmeridth

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v3 regression: PermissionError writing to $GITHUB_OUTPUT as non-root user

2 participants

@jmeridth
[8]ページ先頭
©2009-2025 Movatter.jp