- Notifications
You must be signed in to change notification settings - Fork44
throw errors rather than resolving them#87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
koddsson approved these changesDec 1, 2022
Contributor
lgarron commentedDec 2, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ah, it looks like I misunderstood what include-fragment-element/src/index.ts Line 171 inc405e3a
Thanks for the fix! |
Comment on lines 199 to 201
| if (data instanceof Error) { | ||
| return data | ||
| throw data | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might now be unreachable and safe to remove?
lgarron added a commit that referenced this pull requestDec 2, 2022
lgarron added a commit that referenced this pull requestDec 2, 2022
lgarron added a commit that referenced this pull requestDec 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lgarron a slight change in the API to be more idiomatic (and also backwards compatible).
Instead of returning Error objects, we throw them so the Promise rejects.