Commit75ac8d9

authored

Merge pull request#108 from github/manuelpuyol-patch-1

Send error information to event

2 parents4254978 +45014a6 commit75ac8d9Copy full SHA for 75ac8d9

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -220,10 +220,10 @@ export class IncludeFragmentElement extends HTMLElement {`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`// Functional stand in for the W3 spec "queue a task" paradigm`
`223`		`-async #task(eventsToDispatch:string[]):Promise<void>{`
	`223`	`+async #task(eventsToDispatch:string[],error?:Error):Promise<void>{`
`224`	`224`	`awaitnewPromise(resolve=>setTimeout(resolve,0))`
`225`	`225`	`for(consteventTypeofeventsToDispatch){`
`226`		`-this.dispatchEvent(newEvent(eventType))`
	`226`	`+this.dispatchEvent(error ?newCustomEvent(eventType,{detail:{error}}) :newEvent(eventType))`
`227`	`227`	`}`
`228`	`228`	`}`
`229`	`229`
`@@ -258,7 +258,7 @@ export class IncludeFragmentElement extends HTMLElement {`
`258`	`258`	// Dispatch `error` and `loadend` async to allow
`259`	`259`	// the `load()` promise to resolve _before_ these
`260`	`260`	`// events are fired.`
`261`		`-this.#task(['error','loadend'])`
	`261`	`+this.#task(['error','loadend'],errorasError)`
`262`	`262`	`throwerror`
`263`	`263`	`}`
`264`	`264`	`}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -342,6 +342,8 @@ suite('include-fragment-element', function () {`
`342`	`342`	`constevent=awaitwhen(div.firstChild,'error')`
`343`	`343`	`assert.equal(event.bubbles,false)`
`344`	`344`	`assert.equal(event.cancelable,false)`
	`345`	`+assert.instanceOf(event.detail.error,Error)`
	`346`	`+assert.equal(event.detail.error.message,'Failed to load resource: the server responded with a status of 500')`
`345`	`347`	`})`
`346`	`348`
`347`	`349`	`test('adds is-error class on 500 status',asyncfunction(){`

Comments

(0)