Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

assert params and body in repositories_test#96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
williammartin merged 1 commit intomainfromjuruen/repository-test
Apr 4, 2025

Conversation

juruen
Copy link
Collaborator

@juruenjuruen commentedApr 4, 2025•
edited
Loading

Context

Follow-up PR to#95 to continue improving our test coverage. These changes assert that the request parameters and body are correctly handled in therepositories_test file.

@CopilotCopilotAI review requested due to automatic review settingsApril 4, 2025 10:33
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enhances test coverage in the repository tests by asserting that request parameters and request bodies are correctly handled.

  • Replaces mock.WithRequestMatch with mock.WithRequestMatchHandler across multiple test cases.
  • Introduces explicit assertions for query parameters and request bodies in tests.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon.Learn more

@juruenjuruen marked this pull request as draftApril 4, 2025 10:33
@juruenjuruenforce-pushed thejuruen/repository-test branch 2 times, most recently fromcc1bc67 toae4cbd0CompareApril 4, 2025 10:38
@juruenjuruen changed the titleassert params and body in repository_testassert params and body in repositories_testApr 4, 2025
@juruenjuruen marked this pull request as ready for reviewApril 4, 2025 10:49
@juruenjuruenforce-pushed thejuruen/repository-test branch fromae4cbd0 to5c5f42fCompareApril 4, 2025 11:58
@williammartinwilliammartin merged commitccaedb6 intomainApr 4, 2025
16 checks passed
@williammartinwilliammartin deleted the juruen/repository-test branchApril 4, 2025 12:32
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull requestApr 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@williammartinwilliammartinwilliammartin approved these changes

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@juruen@williammartin@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp