assert request params and body in pull_request_test#95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

juruen merged 1 commit intomainfromjuruen/pr-assert

Apr 4, 2025

Merged

assert request params and body in pull_request_test#95

juruen merged 1 commit intomainfromjuruen/pr-assert

Apr 4, 2025

Conversation

Copy link

Collaborator

juruen commentedApr 4, 2025

Context

Follow-up PR to#94 to continue improving our test coverage. These changes assert that the request parameters and body are correctly handled in thepull_request_test file.

assert request params and body

278ec38

CopilotAI review requested due to automatic review settings

April 4, 2025 10:12

CopilotAI reviewed

Apr 4, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR improves test coverage for pull request operations by asserting that the request parameters and request body payloads are correctly handled.

Updates the HTTP client mock to use handler functions that verify query parameters and request bodies.
Adds assertions for various endpoints such as listing, merging, updating branches, and creating reviews/PRs.

Comments suppressed due to low confidence (2)

pkg/github/pullrequests_test.go:700

[nitpick] The test for updating the pull request branch using an empty request body may benefit from an explanatory comment clarifying why an empty body is expected.

expectRequestBody(t, map[string]interface{}{}).andThen(

pkg/github/pullrequests_test.go:1109

[nitpick] Consider verifying that the explicit use of float64 for the 'position' field is intentional; if the expected type is an integer, using an int literal (with a conversion if necessary) could improve clarity.