- Notifications
You must be signed in to change notification settings - Fork899
assert request params in code_scanning_test#94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the code scanning alerts test to assert that the expected query parameters are included in the GitHub API request.
- Replaces mock.WithRequestMatch with mock.WithRequestMatchHandler to allow for more flexible request matching.
- Introduces the expectQueryParams helper to assert that parameters "ref", "state", and "severity" are correctly set.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab.Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM thanks!
e267a3c intomainUh oh!
There was an error while loading.Please reload this page.
Context
This makes use of the new helper functionality to assert the right code scanning parameters are passed to the GH API request.