- Notifications
You must be signed in to change notification settings - Fork897
speed up docker builds#92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This pull request updates the runner configuration in the docker publishing workflow by increasing the runner size to "xl".
- Modify the runner type from "ubuntu-latest" to "ubuntu-latest-xl"
- Adjust workflow configuration to potentially access higher resource runners
Comments suppressed due to low confidence (1)
.github/workflows/docker-publish.yml:26
- Please verify that 'ubuntu-latest-xl' is a valid runner label for this workflow. If it is not available on GitHub MCP Server, consider updating to a valid runner specification to prevent workflow failures.
runs-on: ubuntu-latest-xlTip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon.Learn more
SamMorrowDrums previously approved these changesApr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice 🚀
SamMorrowDrums approved these changesApr 3, 2025
9e2b1f0 intomain 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull requestApr 12, 2025
williammartin pushed a commit that referenced this pull requestMay 7, 2025
* Optimize Docker build with bind mountsThis commit further optimize the Docker builds on top of PR#92 with:1. Add .dockerignore file to exclude non-source code files [1].2. Use Alpine image variant for build stage to reduce download size. golang:1.23.7-alpine is 200 MB smaller than golang:1.23.7 [2][3].3. Replace COPY instruction with RUN --mount=type=bind. Bind mounts do not add unnecessary layers to the cache [4][5].[1]:https://docs.docker.com/build-cloud/optimization/#dockerignore-files[2]:https://hub.docker.com/layers/library/golang/1.23.7-alpine/images/sha256-333d4ba78773b3a3ae9cf2cff8962df56effc5c9481faa355f211abf2baf175c[3]:https://hub.docker.com/layers/library/golang/1.23.7/images/sha256-2087a99c3235972660b3d35c1564d9d1a3f639dcace9c790acbabc7e938d1570[4]:https://docs.docker.com/build/building/best-practices/#add-or-copy[5]:https://docs.docker.com/build/cache/optimize/#use-bind-mountsSigned-off-by: Eng Zer Jun <engzerjun@gmail.com>* Remove `go mod download` step`go build` will automatically download module dependencies. In manycases, that is a much smaller set of modules than what is downloaded by`go mod download`.Size of GOMODCACHE with `go mod download:$ go clean -i -r -cache -modcache$ go mod download$ du -sh ~/go/pkg/mod186M/home/jun/go/pkg/modSize of GOMODCACHE with `go build`:$ go clean -i -r -cache -modcache$ CGO_ENABLED=0 go build -ldflags="-s -w" cmd/github-mcp-server/main.gogo: downloading github.com/spf13/viper v1.20.1go: downloading github.com/mark3labs/mcp-go v0.18.0go: downloading github.com/google/go-github/v69 v69.2.0go: downloading github.com/sirupsen/logrus v1.9.3go: downloading github.com/spf13/cobra v1.9.1go: downloading golang.org/x/sys v0.31.0go: downloading github.com/spf13/afero v1.14.0go: downloading github.com/fsnotify/fsnotify v1.8.0go: downloading github.com/spf13/cast v1.7.1go: downloading github.com/go-viper/mapstructure/v2 v2.2.1go: downloading github.com/subosito/gotenv v1.6.0go: downloading gopkg.in/yaml.v3 v3.0.1go: downloading github.com/spf13/pflag v1.0.6go: downloading github.com/pelletier/go-toml/v2 v2.2.3go: downloading github.com/sagikazarmark/locafero v0.9.0go: downloading golang.org/x/text v0.23.0go: downloading github.com/google/uuid v1.6.0go: downloading github.com/yosida95/uritemplate/v3 v3.0.2go: downloading github.com/sourcegraph/conc v0.3.0go: downloading github.com/google/go-querystring v1.1.0$ du -sh ~/go/pkg/mod80M/home/jun/go/pkg/modReference:https://stackoverflow.com/a/68172023/7902371Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes:#91
Reduces runtime of the action from8.5 minutes to around1.5 minutes